Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Span and Heading Component as Functional Component #7027

Merged
merged 23 commits into from
Nov 13, 2024
Merged

Refactoring Span and Heading Component as Functional Component #7027

merged 23 commits into from
Nov 13, 2024

Conversation

Makko74
Copy link
Contributor

@Makko74 Makko74 commented Nov 6, 2024 •
edited
Loading

ref #6960

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Maturation completed and documented
  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • No TODOs or commented out code in the final commit
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@Makko74 Makko74 linked an issue Nov 6, 2024 that may be closed by this pull request
Kol-Span als stateless FC ablösen #6960
Closed
@Makko74 Makko74 requested review from deleonio and sdvg and removed request for sdvg and deleonio November 6, 2024 20:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6734c3804ad5cb11739cd19a--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6734c3804ad5cb11739cd19a

@Makko74 Makko74 force-pushed the refactoring/6960-span-component branch from f6e4f56 to bd4c785 Compare November 6, 2024 22:04
@deleonio deleonio changed the base branch from develop to refactoring/6961-heading-component November 7, 2024 07:44
@deleonio deleonio changed the base branch from refactoring/6961-heading-component to refactoring/6963-change-component-snapshot-tests November 8, 2024 07:44
@deleonio deleonio changed the title Refactoring/6960 span component Refactoring/6960 span component (2/4) Nov 8, 2024
Base automatically changed from refactoring/6963-change-component-snapshot-tests to develop November 8, 2024 10:33
@Makko74
Merge branch 'develop' into refactoring/6960-span-component
b2e7026 
# Conflicts:
#	packages/components/src/components/abbr/test/snapshot.spec.tsx
#	packages/components/src/components/accordion/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/accordion/test/snapshot.spec.tsx
#	packages/components/src/components/alert/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/alert/test/snapshot.spec.tsx
#	packages/components/src/components/badge/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/badge/test/snapshot.spec.tsx
#	packages/components/src/components/breadcrumb/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/breadcrumb/test/snapshot.spec.tsx
#	packages/components/src/components/button-group/test/snapshot.spec.tsx
#	packages/components/src/components/button-link/test/snapshot.spec.tsx
#	packages/components/src/components/button/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/button/test/snapshot.spec.tsx
#	packages/components/src/components/card/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/card/test/snapshot.spec.tsx
#	packages/components/src/components/combobox/test/snapshot.spec.tsx
#	packages/components/src/components/details/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/details/test/snapshot.spec.tsx
#	packages/components/src/components/drawer/test/snapshot.spec.tsx
#	packages/components/src/components/form/test/snapshot.spec.tsx
#	packages/components/src/components/heading/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/heading/test/snapshot.spec.tsx
#	packages/components/src/components/icon/test/snapshot.spec.tsx
#	packages/components/src/components/image/test/snapshot.spec.tsx
#	packages/components/src/components/indented-text/test/snapshot.spec.tsx
#	packages/components/src/components/link-button/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/link-button/test/snapshot.spec.tsx
#	packages/components/src/components/link-group/test/snapshot.spec.tsx
#	packages/components/src/components/link/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/link/test/snapshot.spec.tsx
#	packages/components/src/components/modal/test/snapshot.spec.tsx
#	packages/components/src/components/nav/test/snapshot.spec.tsx
#	packages/components/src/components/pagination/test/snapshot.spec.tsx
#	packages/components/src/components/popover/test/snapshot.spec.tsx
#	packages/components/src/components/quote/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/quote/test/snapshot.spec.tsx
#	packages/components/src/components/skip-nav/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/skip-nav/test/snapshot.spec.tsx
#	packages/components/src/components/span/test/snapshot.spec.tsx
#	packages/components/src/components/spin/test/snapshot.spec.tsx
#	packages/components/src/components/split-button/test/snapshot.spec.tsx
#	packages/components/src/components/symbol/test/snapshot.spec.tsx
#	packages/components/src/components/tabs/test/snapshot.spec.tsx
#	packages/components/src/components/toolbar/test/snapshot.spec.tsx
#	packages/components/src/components/tooltip/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/tooltip/test/snapshot.spec.tsx
#	packages/components/src/components/tree-item/test/__snapshots__/snapshot.spec.tsx.snap
#	packages/components/src/components/tree-item/test/snapshot.spec.tsx
#	packages/components/src/components/tree/test/snapshot.spec.tsx
#	packages/components/src/components/version/test/snapshot.spec.tsx

Refs: #6960
@Makko74
snapshot fix
1e39fc8 
Refs: #6960
@Makko74 Makko74 changed the title Refactoring/6960 span component (2/4) Refactoring Span Component as Functional Component Nov 8, 2024
@Makko74 Makko74 linked an issue Nov 8, 2024 that may be closed by this pull request
KolHeadingWc als stateless FC ablösen #6961
Closed
@sdvg sdvg self-requested a review November 8, 2024 13:16
@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Nov 12, 2024
@Makko74 Makko74 changed the title Refactoring Span Component as Functional Component Refactoring Span and Heading Component as Functional Component Nov 12, 2024
@sdvg sdvg mentioned this pull request Nov 12, 2024
Closed
sdvg
sdvg requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gefällt mir sehr gut 👍
Habe nur ein paar ganz kleine Anmerkungen.

packages/components/src/functional-components/Span/Span.tsx Outdated Show resolved Hide resolved
packages/components/src/schema/components/badge.ts Outdated Show resolved Hide resolved
packages/components/src/components/heading/shadow.tsx Outdated Show resolved Hide resolved
@sdvg sdvg merged commit 4a51be7 into develop Nov 13, 2024
10 checks passed
@sdvg sdvg deleted the refactoring/6960-span-component branch November 13, 2024 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@deleonio deleonio restored the refactoring/6960-span-component branch November 13, 2024 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KolHeadingWc als stateless FC ablösen Kol-Span als stateless FC ablösen
3 participants
@Makko74 @sdvg @deleonio