Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external link #7007

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Add external link #7007

merged 6 commits into from
Nov 11, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Nov 5, 2024 •
edited
Loading

Refs: #6875

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Maturation completed and documented
  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • No TODOs or commented out code in the final commit
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne linked an issue Nov 5, 2024 that may be closed by this pull request
Style-Optimierung am Link und Button-Link #6875
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6731ed8fc1dda007beb7cbde--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6731ed8fc1dda007beb7cbde

@deleonio deleonio self-requested a review November 6, 2024 20:54
deleonio
deleonio requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fehlt hier nicht eine Snapshot-Änderung?! Oder wird die Link-Icon-Seite nicht gesnapshotted?

deleonio
deleonio requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kannst du bitte hier gleich in den Themes den Abstand zum Icon new Tab fixen. Das klebt da direkt dran. Ggf geht das direkt über Basis-Styling

@anicyne anicyne force-pushed the 6875-add-external-link branch from c4ee04f to a3a3295 Compare November 11, 2024 10:08
@anicyne anicyne force-pushed the 6875-add-external-link branch from da9c809 to 8eb2e87 Compare November 11, 2024 11:26
@anicyne anicyne requested a review from deleonio November 11, 2024 11:51
@deleonio deleonio merged commit 7e392bf into develop Nov 11, 2024
10 checks passed
@deleonio deleonio deleted the 6875-add-external-link branch November 11, 2024 12:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style-Optimierung am Link und Button-Link
2 participants
@anicyne @deleonio