Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KolAlert: Always include icon label (i.e. alert type) in accessibility tree. #6932

Merged
merged 8 commits into from
Oct 22, 2024
Merged

KolAlert: Always include icon label (i.e. alert type) in accessibility tree. #6932

merged 8 commits into from
Oct 22, 2024

Conversation

AlexanderSchmidtCE
Copy link
Contributor

No description provided.

@AlexanderSchmidtCE AlexanderSchmidtCE linked an issue Oct 16, 2024 that may be closed by this pull request
🐞 Bug: 9.1.1.1 - alert: Inkonsistentes Verhalten der Alternativtexte der Benachrichtigungssymbole #6631
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://67167dffe7ee36743dd3f4ea--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67167dffe7ee36743dd3f4ea

@AlexanderSchmidtCE
format
e1295f8 
Refs: #6631
@AlexanderSchmidtCE AlexanderSchmidtCE changed the title Screen reader now read alert-type and label on alert-icon Screen reader now read alert-type and label on alert-icon of KolAlert Oct 16, 2024
@sdvg sdvg self-requested a review October 21, 2024 08:10
sdvg
sdvg reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vorschlag für den PR Titel (=Changelog):

KolAlert: Always include icon label (i.e. alert type) in accessibility tree.

sdvg
sdvg requested changes Oct 21, 2024
View reviewed changes
packages/components/src/components/alert/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/alert/readme.md Outdated Show resolved Hide resolved
packages/components/src/components/alert/readme.md Outdated Show resolved Hide resolved
packages/components/src/components/alert/test/html.mock.ts Outdated Show resolved Hide resolved
packages/components/src/components/alert/test/html.mock.ts Outdated Show resolved Hide resolved
@AlexanderSchmidtCE AlexanderSchmidtCE changed the title Screen reader now read alert-type and label on alert-icon of KolAlert KolAlert: Always include icon label (i.e. alert type) in accessibility tree. Oct 21, 2024
@deleonio deleonio merged commit 56666a1 into develop Oct 22, 2024
5 checks passed
@deleonio deleonio deleted the 6631-bug-9111-alert-inkonsistentes-verhalten-der-alternativtexte-der-benachrichtigungssymbole branch October 22, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: 9.1.1.1 - alert: Inkonsistentes Verhalten der Alternativtexte der Benachrichtigungssymbole
3 participants
@AlexanderSchmidtCE @sdvg @deleonio