Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor line-heights to use relative values #6871

Merged
merged 28 commits into from
Oct 9, 2024
Merged

Refactor line-heights to use relative values #6871

merged 28 commits into from
Oct 9, 2024

Conversation

Makko74
Copy link
Contributor

@Makko74 Makko74 commented Sep 24, 2024

Refs: #6835

@Makko74 Makko74 linked an issue Sep 24, 2024 that may be closed by this pull request
Bei Line-Height im CSS überall wo em oder rem verwendet wurde, einfach die Einheit weglassen #6835
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://6706830008fec55e5f9abbfe--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6706830008fec55e5f9abbfe

Makko74 and others added 15 commits September 27, 2024 21:49
@Makko74
restructure theme ecl
87c24ad 
Refs: #6835
@Makko74
theme ecl-ec: refactoring line-height
262ffb4 
Refs: #6835
@Makko74 @publicuibot
Update all snapshots$
9a248b3 
$
Refs: #6835
@Makko74
theme ecl-eu: refactoring line-height
d6b7a26 
Refs: #6835
@Makko74
remove importants
c0094f4 
Refs: #6835
@Makko74
theme default: input
6fe5cad 
Refs: #6835
@Makko74
theme default: input
f15180b 
Refs: #6835
@Makko74
fix
cc4a945 
Refs: #6835
@Makko74
theme default: remove important
cc0279e 
Refs: #6835
@Makko74
theme default: line-height
d39c6c0 
Refs: #6835
@Makko74 @publicuibot
Update all snapshots$
ef18ce1 
$
Refs: #6835
@Makko74
theme default: fix msg
e2cef47 
Refs: #6835
@Makko74
Revert "Update all snapshots$"
76da3b5 
This reverts commit ef18ce1.

Refs: #6835
@Makko74 @publicuibot
Update all snapshots$
918723b 
$
Refs: #6835
@laske185
Merge branch 'feature/revert-deps-update' into feature/6835-refectori…
0e53310 
…ng-themes-line-height

# Conflicts:
#	packages/adapters/react/package.json
@laske185 laske185 marked this pull request as ready for review October 7, 2024 11:21
@laske185 laske185 linked an issue Oct 7, 2024 that may be closed by this pull request
🛠️ Todo: border-width: 0 !important; bei Alert-Styling prüfen #6169
Closed
2 tasks
@sdvg sdvg changed the title feature/6835 line-height refactoring Refactor line-heights to use relative values Oct 8, 2024
sdvg
sdvg requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke für die Refactorings, viel besser 😃

packages/themes/bmf/src/components/combobox.scss Outdated Show resolved Hide resolved
packages/themes/bmf/src/components/combobox.scss Outdated Show resolved Hide resolved
packages/themes/bmf/src/components/input-radio.scss Outdated Show resolved Hide resolved
packages/themes/bmf/src/mixins/typography.scss Show resolved Hide resolved
packages/themes/itzbund/src/components/select.scss Outdated Show resolved Hide resolved
packages/themes/itzbund/src/components/single-select.scss Outdated Show resolved Hide resolved
Makko74 added 2 commits October 9, 2024 09:20
@Makko74
fixes
b371797 
Refs: #6835
@Makko74
fix
447af20 
Refs: #6835
@Makko74 Makko74 requested a review from sdvg October 9, 2024 08:12
@sdvg sdvg merged commit 0d9f5e9 into develop Oct 9, 2024
5 checks passed
@sdvg sdvg deleted the feature/6835-refectoring-themes-line-height branch October 9, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

@laske185 laske185 Awaiting requested review from laske185

@deleonio deleonio Awaiting requested review from deleonio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Makko74 @sdvg @deleonio @laske185