Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs: Ensure correct counter value for initial values #6800

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Inputs: Ensure correct counter value for initial values #6800

merged 3 commits into from
Sep 10, 2024

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Sep 9, 2024

No description provided.

@sdvg sdvg linked an issue Sep 9, 2024 that may be closed by this pull request
Bug: Input-Counter zeigt Länge eines Default-Wertes nicht initial an #6774
Closed
@sdvg sdvg marked this pull request as draft September 9, 2024 15:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://66df16135e10341d25a2fd05--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/66df16135e10341d25a2fd05

@sdvg sdvg marked this pull request as ready for review September 9, 2024 16:07
laske185
laske185 requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@laske185 laske185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der Counter fehlt bei Email und Passwort.

@sdvg
Copy link
Member Author

sdvg commented Sep 10, 2024 •
edited
Loading

@laske185

Der Counter fehlt bei Email und Passwort.

Der Counter bei Email und Passwort funktioniert grundsätzlich, das wird auch durch die E2E-Tests verifiziert.

Im Refinement hatten wir beschlossen, dass wir neben der zweiten Textarea keine weiteren Beispiele hinzufügen (und so verstehe ich auch die Ticketspezifikation). Sollen wir das doch machen?

@laske185
Copy link
Contributor

Da der Counter über Tests auch bei E-Mail und Passwort abgeprüft wird, haben wir uns geeinigt, dass wir die Samples nicht weiter unnötig größer machen.

@laske185 laske185 merged commit 06c7d4e into develop Sep 10, 2024
5 checks passed
@laske185 laske185 deleted the 6774-input-counter-initial branch September 10, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laske185 laske185 laske185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Input-Counter zeigt Länge eines Default-Wertes nicht initial an
2 participants
@sdvg @laske185