Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs with behavior propety and select manual mode #6761

Merged
merged 14 commits into from
Sep 11, 2024
Merged

tabs with behavior propety and select manual mode #6761

merged 14 commits into from
Sep 11, 2024

Conversation

Makko74
Copy link
Contributor

@Makko74 Makko74 commented Aug 29, 2024

Refs: #6249

@Makko74 Makko74 linked an issue Aug 29, 2024 that may be closed by this pull request
🛹 Feature: Tabs new _behavior property for alternative control #6249
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://66e16a4b1b3facdaebb940e0--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/66e16a4b1b3facdaebb940e0

deleonio
deleonio reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdvg, @Makko74, @laske185 über diesen PR sollten wir gemeinsam sprechen.

@deleonio deleonio added the nok PR is not okay. label Sep 6, 2024
@Makko74
Copy link
Contributor Author

Makko74 commented Sep 9, 2024

@deleonio @sdvg

Ich glaube es wäre sinnvoll den Inhalt von KolTabs in einen ValidationController, KeyboardController aufzuteilen. So dass im KolTab nur noch die Props, Watch und das Rendering drin sind. KeyboardController kann auch anders heißen, dieser würde die Logik übernehmen um in der Liste zu navigieren (Irgendwie kommt dies im Projekt häufiger vor, also das Navigieren in einer Liste)

@Makko74 Makko74 requested review from deleonio and sdvg September 10, 2024 08:26
@Makko74 Makko74 requested a review from sdvg September 10, 2024 10:48
@sdvg sdvg changed the title tabs with behavior propety and select manuel mode tabs with behavior propety and select manual mode Sep 10, 2024
deleonio
deleonio previously approved these changes Sep 10, 2024
View reviewed changes
@deleonio
Copy link
Contributor

@deleonio @sdvg

Ich glaube es wäre sinnvoll den Inhalt von KolTabs in einen ValidationController, KeyboardController aufzuteilen. So dass im KolTab nur noch die Props, Watch und das Rendering drin sind. KeyboardController kann auch anders heißen, dieser würde die Logik übernehmen um in der Liste zu navigieren (Irgendwie kommt dies im Projekt häufiger vor, also das Navigieren in einer Liste)

Lege gerne hierzu ein neues Ticket an.

@sdvg sdvg removed the nok PR is not okay. label Sep 11, 2024
@sdvg sdvg merged commit 4ab1f43 into develop Sep 11, 2024
5 checks passed
@sdvg sdvg deleted the feature/6249-tabs-with-behavior-property branch September 11, 2024 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

@deleonio deleonio deleonio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛹 Feature: Tabs new _behavior property for alternative control
3 participants
@Makko74 @deleonio @sdvg