-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of SingleSelect with filter function #6546
Conversation
Netlify Draft Deployment |
…694-feature-singleselect-component
ed62da1
to
fc7bc9f
Compare
07a0e84
to
6316653
Compare
6316653
to
25063a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steht vermutlich nicht im Ticket, aber wir sollten neue Inputs immer auch in den entsprechenden Szenarien ergänzen:
- inputs-get-value
- static-form
- focus-elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Könntest du die Events anhand der Szenarien bitte einmal durchtesten und korrigieren:
- bei
onInput
bekomme ich numbers statt der Werte. - ich sehe teilweise Exceptions.
- bei meinem letzten Test bekam ich
false
als Wert.
Falls du die Fehler nicht reproduzieren kannst geb gerne noch mal Bescheid, dann dokumentiere ich die Schritte genauer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/samples/react/src/components/single-select/partials/variants.tsx
Outdated
Show resolved
Hide resolved
…com/public-ui/kolibri into 3694-feature-singleselect-component
$ Refs: #3694
Es gibt noch ein Problem mit dem Fokus-Verschieben mit der Maus. Zum Reproduzieren:
Soll: Die letzte Option in der Liste ist fokussiert. |
…com/public-ui/kolibri into 3694-feature-singleselect-component
…ure-singleselect-component * 'develop' of github.com:public-ui/kolibri: (43 commits) Remove KolSpan from component-list.ts fix: correct handling of invalid date inputs Remove KolSpan implementation (#6568) Review changes (#6568) Review changes cleanup Add more e2e test sample Move e2e tests to components folder Revert test change Test failing test run on CI Fix playwright install Migrate Playwright tests to CI workflow Move workflow file Fix Safari tests Configure Playwright E2E tests with setContent pattern (#6568) Added label translations to table selection (#6568) Added selection control to table component and refactored some code chore: release 2.1.4 Update Readme files Update publish.yml ...
$ Refs: #3694
Refs: #3694
…ent' into 3694-feature-singleselect-component * origin/3694-feature-singleselect-component: Update all snapshots$ $ Refs: #3694
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wenn ich in das Feld klicke, dann verliert das Eingabefeld den Fokus wieder. Das Problem hatten wir auch schon bei der Combobox, wo es gelöst ist.
…ure-singleselect-component * 'develop' of github.com:public-ui/kolibri: (76 commits) chore: release 2.1.6 Update SECURITY.md chore: update deps refact: the hash code Update all snapshots$ $ Refs: #6674 Set default radio button selection in drawer controlled sample Adjust Root Font size in badge, drawer and icon components Fix: use location.hash instead of location.href Remove faulty proxy option from inherited webpack config Fix bin path Remove version number from banner Always show error logs chore: release 2.1.5 fix: react sample bootstrap allow setting the dev mode via bootstrap Add code links for components Update all snapshots$ $ Refs: #6559 Revert publiccode.yml Reset lerna version Reset versions ...
$ Refs: #3694
Refs: #3694