Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng/add angular app sample #6220

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Ng/add angular app sample #6220

merged 4 commits into from
Mar 20, 2024

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Mar 15, 2024 •
edited by sdvg
Loading

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • Code review performed successfully
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully or not relevant

@deleonio deleonio marked this pull request as draft March 15, 2024 07:16
@deleonio deleonio self-assigned this Mar 15, 2024
@deleonio deleonio added the v2 label Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65f406440bc7432feda2bf00--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65f406440bc7432feda2bf00

@deleonio deleonio requested a review from sdvg March 15, 2024 07:54
@deleonio deleonio linked an issue Mar 15, 2024 that may be closed by this pull request
🛠️ Todo: Add angular app sample #6222
Closed
@deleonio deleonio marked this pull request as ready for review March 15, 2024 07:58
sdvg
sdvg reviewed Mar 15, 2024
View reviewed changes
packages/samples/angular/.editorconfig Outdated

[*]
charset = utf-8
indent_style = space
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist die Abweichung vom Projekt-Standard gewollt?
Ich glaube wir könnten diese editorconfig einfach entfernen, dann wird die vom Monorepo verwendet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hab es mal auf den Standard Angular Way erstellt. Aber im Mono-Repo passt das wirklich nicht rein.

sdvg
sdvg previously approved these changes Mar 15, 2024
View reviewed changes
@deleonio deleonio merged commit c27f0ba into develop Mar 20, 2024
3 of 4 checks passed
@deleonio deleonio deleted the ng/add-angular-app-sample branch March 20, 2024 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg left review comments

Assignees

@deleonio deleonio

Labels
v2
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ Todo: Add angular app sample
2 participants
@deleonio @sdvg