Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add stencil sass plugin and refactor all css stuff to scss #6125

Merged

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Feb 26, 2024

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • A11y tests performed successfully
  • Code review carried out successfully
  • Manual test performed successfully

@deleonio deleonio added the v2 label Feb 26, 2024
@deleonio deleonio requested a review from sdvg February 26, 2024 16:01
@deleonio deleonio self-assigned this Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

@deleonio deleonio linked an issue Feb 26, 2024 that may be closed by this pull request
4 tasks
@layer kol-component {
.container {
border-radius: 50%;
overflow: hidden;
outline: transparent solid 1px; /* Visible with forced colors */
outline: transparent solid 1px;
/* Visible with forced colors */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sollten diese Kommentare über der betroffene Zeile stehen?

sdvg
sdvg previously approved these changes Feb 26, 2024
@deleonio deleonio force-pushed the refactor-v2/add-stencil-sass-plugin-and-refactor-to-scss branch from aeadd7a to 88fdbca Compare February 27, 2024 05:48
@layer kol-component {
.container {
border-radius: 50%;
overflow: hidden;
outline: transparent solid 1px; /* Visible with forced colors */
/* Visible with forced colors */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laske185 - kein commit - der Kommentar steht über der CSS-Definition. GitHub zeigt wohl nicht immer das aktuellste an?!

@deleonio deleonio merged commit cd70129 into develop Feb 27, 2024
6 of 7 checks passed
@deleonio deleonio deleted the refactor-v2/add-stencil-sass-plugin-and-refactor-to-scss branch February 27, 2024 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐞 Firefox-Bug: Nested Styles mit Version 115.6.0esr defekt
3 participants