Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Modal and I18n from Window #6119

Merged
merged 1 commit into from
Feb 28, 2024
Merged

refactor: remove Modal and I18n from Window #6119

merged 1 commit into from
Feb 28, 2024

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Feb 24, 2024 •
edited by sdvg
Loading

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • A11y tests performed successfully
  • Code review carried out successfully
  • Manual test performed successfully

@deleonio deleonio added the v2 label Feb 24, 2024
@deleonio deleonio requested review from sdvg and laske185 February 24, 2024 06:34
@deleonio deleonio self-assigned this Feb 24, 2024
@deleonio deleonio mentioned this pull request Feb 24, 2024
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65dee185eb4ffeb540014c3f--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65dee185eb4ffeb540014c3f

@deleonio deleonio force-pushed the refactor-v2/remove-modal-and-i18n-from-window branch 2 times, most recently from 63c9b12 to 73204d4 Compare February 26, 2024 06:13
sdvg
sdvg reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deleonio Allgemeine Frage: Was spricht eigentlich dagegen, configKoliBri und bootstrap zusammenzulegen?

@deleonio deleonio force-pushed the refactor-v2/remove-modal-and-i18n-from-window branch from 1974c7a to 582def7 Compare February 28, 2024 06:22
@deleonio deleonio requested a review from sdvg February 28, 2024 06:22
@deleonio deleonio force-pushed the refactor-v2/remove-modal-and-i18n-from-window branch from 582def7 to 6f7f5ca Compare February 28, 2024 07:29
@deleonio deleonio linked an issue Feb 28, 2024 that may be closed by this pull request
🛹 Feature: Mehrere KoliBri-Versionen gleichzeitig nutzen #6019
Closed
@deleonio deleonio removed the request for review from laske185 February 28, 2024 12:19
@sdvg sdvg merged commit 00cda31 into fix-v2-develop/register-kolibri-once Feb 28, 2024
4 of 7 checks passed
@sdvg sdvg deleted the refactor-v2/remove-modal-and-i18n-from-window branch February 28, 2024 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees

@deleonio deleonio

Labels
v2
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛹 Feature: Mehrere KoliBri-Versionen gleichzeitig nutzen
2 participants
@deleonio @sdvg