Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab styling in forced-colors-mode #6027

Merged
merged 11 commits into from
Feb 15, 2024
Merged

Fix tab styling in forced-colors-mode #6027

merged 11 commits into from
Feb 15, 2024

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Feb 8, 2024 •
edited
Loading

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Pull request linked to one or more issues
    • Acceptance criteria of the linked issue satisfied
    • All changes relates to the issue
  • All tests passed
    • Code changes tested manually if not covered by automated tests
    • A11y tests successful carried out

sdvg added 4 commits February 8, 2024 11:37
@sdvg
Backport improved tab sample from develop
b1f4953
@sdvg
Backport tab style changes from develop
1380608
@sdvg
Merge branch 'release/1.7' of github.com:public-ui/kolibri into 5801-…
1b41493 
…active-tab-styling

* 'release/1.7' of github.com:public-ui/kolibri:
  update test scripts in package.json for ecl theme
  update test scripts in package.json
  Fix formatting errors
  Remove extra backslash in scss content value
  remove scss layers
  Move itzbund and default themes styles into scss files
  Move ecl themes styles into scss files
  Add scss support to `themes` module
  Move default theme styles into scss files
  update default theme
@sdvg
Backport tab style changes from develop
4a5c0d5
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65c64d9e9bd50d11910b2b8e--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65c64d9e9bd50d11910b2b8e

@sdvg sdvg linked an issue Feb 9, 2024 that may be closed by this pull request
🐞 Bug: 9.1.4.1 tabs: Aktiver Tab ist nur durch Farbe unterscheidbar #5801
Closed
@sdvg sdvg changed the title 5801 active tab styling Fix tab styling in forced-colors-mode Feb 9, 2024
@sdvg sdvg added the v1 label Feb 9, 2024
@sdvg sdvg marked this pull request as ready for review February 12, 2024 07:56
@deleonio
Copy link
Contributor

deleonio commented Feb 12, 2024 •
edited
Loading

Needs a11y-Retest.

@sdvg sdvg merged commit 84989da into release/1.7 Feb 15, 2024
3 of 11 checks passed
@sdvg sdvg deleted the 5801-active-tab-styling branch February 15, 2024 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
a11y-retest v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: 9.1.4.1 tabs: Aktiver Tab ist nur durch Farbe unterscheidbar
2 participants
@sdvg @deleonio