Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: DOD #6014

Merged
merged 5 commits into from
Feb 9, 2024
Merged

chore: DOD #6014

merged 5 commits into from
Feb 9, 2024

Conversation

laske185
Copy link
Contributor

@laske185 laske185 commented Feb 5, 2024 •
edited by deleonio
Loading

☑️ Definition of Done checklist

  • Meaningful title and valuable description in pull request
  • Pull request linked to one or more issues
    • Acceptance criteria of the linked issue satisfied
    • All changes relates to the issue
  • All tests passed
    • Code changes tested manually if not covered by automated tests
    • A11y tests successful carried out

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://65c5d2ea47885c6bbf5c4aae--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/65c5d2ea47885c6bbf5c4aae

@laske185 laske185 requested a review from deleonio February 5, 2024 14:11
@deleonio deleonio marked this pull request as draft February 5, 2024 15:01
laske185 and others added 5 commits February 9, 2024 08:20
@laske185
chore: initital DOD
f33f7d0
@laske185
chore: update DOD criterions
a82dd46
@laske185
chore: use fork
f023e2c
@deleonio @laske185
chore: add ref to the pipeline name and configure concurrency
2d05996 
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
@deleonio @laske185
chore: fix typo
5cb4ed9 
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
@deleonio deleonio marked this pull request as ready for review February 9, 2024 13:40
@deleonio deleonio merged commit c2a4457 into develop Feb 9, 2024
5 checks passed
@deleonio deleonio deleted the dod branch February 9, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laske185 @deleonio