Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛹 Feature: Shortkey ermöglichen bei Tooltips #6251

Closed
6 tasks done
gkollotzek opened this issue Mar 25, 2024 · 1 comment · Fixed by #6957
Closed
6 tasks done

🛹 Feature: Shortkey ermöglichen bei Tooltips #6251

gkollotzek opened this issue Mar 25, 2024 · 1 comment · Fixed by #6957
Assignees
@AlexanderSchmidtCE
Labels
a11y-retest desybri The task is assigned to the DESYBRI design system. feature New feature or request sample Relates to a sample in the sample-react project.

Comments

@gkollotzek
Copy link

gkollotzek commented Mar 25, 2024 •
edited by AlexanderSchmidtCE
Loading

Wie im heutigen gemeinsamen Termin besprochen die Feature Anfrage für Shortkeys:

  • Sieht optisch wie ein Access-Key aus, z.B.
image
  • aber es soll kein accesskey verwendet werden
    (Anwendungsbeispiel: Zuletzt fokussierte Tabellenzeile soll durch Shortkey angezeigt ("A")/ bearbeitet ("B") /gedruckt ("D") werden)
  • Für Screenreader muss versteckter Text angezeigt werden, dass es sich um einen Shortkey handelt
  • Das Event-Handling wird von der Anwendung übernommen (nicht Teil von KoliBri)

To-do

  • Tooltip und Span erweitern
    • Umbenennung der Property "_accessKey" in "_badgeText"
    • Badge bleibt aria-hidden
  • Link, Button, Inputs, Select, Textarea (alle die _accessKey umgesetzt haben)
    • Gleichzeitige Verwendung _accessKey und _shortKey erzeugt Fehler
    • _shortKey setzt BadgeKey am Tooltip
    • Accessability-Text wird erweitert, analog wie _accessKey von Screenreadern vorgelesen wird
  • Samples bei den betroffenen Komponenten anlegen.

Abgrenzung:

OS-Spezifische Steuertasten (Strg, Alt, Win, Cmd) werdem nicht von KoliBri gesetzt. Diese müssen von der Anwendung, z. B. als Font-Icon, korrekt übergeben werden.

Dies muss in der Readme dokumentiert werden.
@laske185 laske185 added feature New feature or request desybri The task is assigned to the DESYBRI design system. labels Apr 16, 2024
@laske185 laske185 moved this to 📄 Ready in KoliBri Board Apr 16, 2024
@laske185 laske185 moved this from 📄 Ready to Backlog in KoliBri Board May 2, 2024
@laske185 laske185 moved this from Backlog to 📄 Ready in KoliBri Board May 2, 2024
@laske185
Copy link
Contributor

Wenn shortkey gesetzt ist, dann muss auch der listener ein Pflichtfeld sein.

@laske185 laske185 removed the status in KoliBri Board Oct 7, 2024
@laske185 laske185 moved this to Backlog in KoliBri Board Oct 14, 2024
@laske185 laske185 added the sample Relates to a sample in the sample-react project. label Oct 17, 2024
@laske185 laske185 moved this from Backlog to 📄 Ready in KoliBri Board Oct 17, 2024
@AlexanderSchmidtCE AlexanderSchmidtCE self-assigned this Oct 21, 2024
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
renamed _accessKey to _badgeText for Span
3671e99 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
renamed InternalUnderlinedAccessKey.tsx to InternalUnderlinedBadgeTex…
7e388a3 
…t.tsx

Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
renamed _accessKey to _badgeKey for Tooltip
2107b7f 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
added ShortKeyPropType
6ae5ac1 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
added _shortKey to Button
6980432 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
added _shortKey to Link
79d89a8 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
added _shortKey to Input && InputText
f52cea6 
use kolSpan for Input

Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 23, 2024
@AlexanderSchmidtCE
fixed error
07966c1 
Refs: #6251
@AlexanderSchmidtCE AlexanderSchmidtCE linked a pull request Oct 23, 2024 that will close this issue
Added ShortKey Prop to Elements with AccessKey #6957
Merged
8 tasks
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
added shortKey for Checkbox
6711773 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
added shortKey to InputColor
818590c 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
added shortKey to InputDate
136e5d2 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
added shortKey to InputEmail
c7afd0a 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
added shortKey to InputFile, -Number, -Password, -Radio, -Range
de54906 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
include renderNoLabel to hide label for inputs
3b214d2 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
addes shortkey for select, single-select and textarea
2cc4a30 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 25, 2024
@AlexanderSchmidtCE
Added scss
ebd688a 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 29, 2024
@AlexanderSchmidtCE
fixed shortkey accessKey and shortkey check in inputs
7ec5b86 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Oct 29, 2024
@AlexanderSchmidtCE
lint
c98d36e 
Refs: #6251
publicuibot bot pushed a commit that referenced this issue Oct 29, 2024
@AlexanderSchmidtCE @publicuibot
Update all snapshots$
e99a29a 
$
Refs: #6251
@sdvg sdvg moved this from 🔍 Review to 🏗 In progress in KoliBri Board Oct 30, 2024
AlexanderSchmidtCE added a commit that referenced this issue Nov 3, 2024
@AlexanderSchmidtCE
devmerge
7cafc83 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 3, 2024
@AlexanderSchmidtCE
review changes
9d82937 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 3, 2024
@AlexanderSchmidtCE
Merge branch 'develop' into 6251--feature-shortkey-ermglichen-bei-too…
6ac13a4 
…ltips

# Conflicts:
#	README.md

Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
reverted tests du execMode:default
d0ee6cc 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
lint fix
1754ccd 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
refactor badgeText util function
fce8dd2 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
added pnpm lock
bfd45bb 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
pnpm lock revert
0b7fccd 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
expanded button-link sample
b18da21 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
changed test in input
7366d0c 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
pnpm-lock.yaml
11e552f 
Refs: #6251
publicuibot bot pushed a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE @publicuibot
Update all snapshots$
be343a7 
$
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
packages revert
eb54e58 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
added pnpm lock
27ed176 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
revert pnpm lock
a065f81 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 7, 2024
@AlexanderSchmidtCE
removed unused mixin
594dc77 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 12, 2024
@AlexanderSchmidtCE
dev merge
9831161 
Refs: #6251
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Nov 12, 2024
AlexanderSchmidtCE added a commit that referenced this issue Nov 12, 2024
@AlexanderSchmidtCE
review changes
d6e8291 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 12, 2024
@AlexanderSchmidtCE
renaming
fa66cf9 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 14, 2024
@AlexanderSchmidtCE
added missing shortkey optional prop
9da6c09 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 14, 2024
@AlexanderSchmidtCE
testfix
b85ae57 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 14, 2024
@AlexanderSchmidtCE
updated executeInputSnapshotTests with shortKEy
3329a6a 
Refs: #6251
AlexanderSchmidtCE added a commit that referenced this issue Nov 14, 2024
@AlexanderSchmidtCE
Merge remote-tracking branch 'origin/6251--feature-shortkey-ermgliche…
e6835af 
…n-bei-tooltips' into 6251--feature-shortkey-ermglichen-bei-tooltips

# Conflicts:
#	packages/components/src/components/span/test/__snapshots__/snapshot.spec.tsx.snap

Refs: #6251
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in KoliBri Board Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderSchmidtCE AlexanderSchmidtCE

Labels
a11y-retest desybri The task is assigned to the DESYBRI design system. feature New feature or request sample Relates to a sample in the sample-react project.
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ShortKey Prop to Elements with AccessKey public-ui/kolibri
3 participants
@laske185 @gkollotzek @AlexanderSchmidtCE