TST/DOC: add tests and use new docstring style for class GitRepo
#397
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 94.79% 95.43% +0.63%
==========================================
Files 51 52 +1
Lines 4037 4208 +171
Branches 953 960 +7
==========================================
+ Hits 3827 4016 +189
+ Misses 117 103 -14
+ Partials 93 89 -4
☔ View full report in Codecov by Sentry. |
2974462 to
5bc5f75
Compare
There was a problem hiding this comment.
Thanks, @TobiasKadelka. Better :)
Left some more comments. And one more general comment:
Switching to temp paths being delivered to the test functions is better. But: Now you get that path and every single test function starts with the exact same thing: git init on that path. I would have imagined to "simply" have a fixture, that delivers an initialized git repo (and more specific types of repos could built on it eventually).
I think the functions are generally fine, but I think we should orientate ourselfs for writing the first line of the getter functions for all properties on the those examples: https://docs.python.org/3.6/library/functions.html#property https://stackoverflow.com/questions/16025462/what-is-the-right-way-to-put-a-docstring-on-python-property
0fb6044 to
157c4b0
Compare
157c4b0 to
7fa15ad
Compare
I updated and added docstrings with the new docstring style, and I normalized quotes, punctuation and line breaks.
7fa15ad to
63da652
Compare
|
Thanks, @TobiasKadelka ! |
This PR adds tests and docstrings for the
GitRepoclass, in parallel to the changes forOnyoRepoduring #394.Changes:
GitRepo