preference to open tab to right of current

fixes brave#217 also part of brave#358
psimyn · Feb 29, 2016 · 97a2339 · 97a2339
1 parent 16cc524
commit 97a2339
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/app/locales/en-US/preferences.l20n b/app/locales/en-US/preferences.l20n
@@ -31,8 +31,11 @@
 <paintTabs "Show tabs in page theme color">
 <tabsPerTabPage "Tabs per tab page">
 <showTabPreviews "Show tab previews on hover">
+<openNewTab "Open new tabs">
+<toTheRight "to the right">
+<atTheEnd "at the end">
 
-/* Prviacy settings page */
+/* Privacy settings page */
 <suggestionTypes "When using the location bar, suggest:">
 <history "History">
 <bookmarks "Bookmarks">

diff --git a/js/about/preferences.js b/js/about/preferences.js
@@ -110,6 +110,13 @@ class SearchTab extends ImmutableComponent {
 class TabsTab extends ImmutableComponent {
   render () {
     return <SettingsList>
+      <SettingItem dataL10nId='openNewTab'>
+        <select value={getSetting(this.props.settings, settings.NEW_TAB_POSITION)}
+          onChange={changeSetting.bind(null, settings.NEW_TAB_POSITION)} >
+          <option data-l10n-id='toTheRight' value='right'/>
+          <option data-l10n-id='atTheEnd' value='end'/>
+        </select>
+      </SettingItem>
       <SettingItem dataL10nId='tabsPerTabPage'>
         <input
           type='number'

diff --git a/js/constants/settings.js b/js/constants/settings.js
@@ -13,6 +13,7 @@ const settings = {
   PAINT_TABS: 'tabs.paint-tabs',
   TABS_PER_TAB_PAGE: 'tabs.tabs-per-tab-page',
   SHOW_TAB_PREVIEWS: 'tabs.show-tab-previews',
+  NEW_TAB_POSITION: 'tabs.new-tab-position',
   // Privacy Tab
   HISTORY_SUGGESTIONS: 'privacy.history-suggestions',
   BOOKMARK_SUGGESTIONS: 'privacy.bookmark-suggestions',
@@ -26,4 +27,3 @@ const settings = {
 }
 
 module.exports = settings
-
diff --git a/js/stores/windowStore.js b/js/stores/windowStore.js
@@ -206,6 +206,9 @@ const doAction = (action) => {
       } else if (action.frameOpts.isPartitioned) {
         nextPartitionNumber = incrementPartitionNumber()
       }
+      if (!action.frameOpts.parentFrameKey && getSetting(settings.NEW_TAB_POSITION) === 'right') {
+        action.frameOpts.parentFrameKey = windowState.get('activeFrameKey')
+      }
       windowState = windowState.merge(FrameStateUtil.addFrame(windowState.get('frames'), action.frameOpts,
         nextKey, nextPartitionNumber, action.openInForeground ? nextKey : windowState.get('activeFrameKey')))
       if (action.openInForeground) {