Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused diagonalizers and linear solvers from occwave::Array2d and occwave::SymBlockMatrix #2679

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Remove unused diagonalizers and linear solvers from occwave::Array2d and occwave::SymBlockMatrix #2679

merged 4 commits into from
Aug 15, 2022

Conversation

TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Aug 12, 2022 •
edited
Loading

Description

These functions are never called anywhere C++-side, and not PSI_API.
This is another shard of the #2642 mega-PR that can be merged independently.

Todos

  • Unused code is removed from occwave::Array2d
  • Unused code is removed from occwave::SymBlockMatrix

Status

  • Ready for review
  • Ready for merge

JonathonMisiewicz
JonathonMisiewicz approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Array2d class needs to go. Happy to see even a bit of it be destroyed.

@TiborGY TiborGY mentioned this pull request Aug 14, 2022
Merged
4 tasks
@loriab loriab added this to the Psi4 1.7 milestone Aug 15, 2022
@loriab loriab added cleanup For issues where the goal is to make Psi4 a little cleaner. occ For issues involving OCC, orbital-optimization and more. labels Aug 15, 2022
@zachglick
Copy link
Contributor

The Array2d class needs to go. Happy to see even a bit of it be destroyed.

I'm not familiar with this class (or the occ module for that matter). What's the motivation for getting rid of it?

@JonathonMisiewicz
Copy link
Contributor

The Array2d class needs to go. Happy to see even a bit of it be destroyed.

I'm not familiar with this class (or the occ module for that matter). What's the motivation for getting rid of it?

Redundancy. It's essentially a symmetry-less Matrix.

@JonathonMisiewicz JonathonMisiewicz merged commit 203d69f into psi4:master Aug 15, 2022
This was referenced Aug 17, 2022
Draft
Merged
@TiborGY TiborGY deleted the patch-8 branch September 10, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

@zachglick zachglick zachglick approved these changes

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
cleanup For issues where the goal is to make Psi4 a little cleaner. occ For issues involving OCC, orbital-optimization and more.
Projects
None yet
Milestone
Psi4 1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@TiborGY @zachglick @JonathonMisiewicz @loriab