Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lose * in ccdensity #2438

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Lose * in ccdensity #2438

merged 1 commit into from
Feb 14, 2022

Conversation

JonathonMisiewicz
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz commented Feb 12, 2022 •
edited
Loading

Description

This PR replaces several int * types in ccdensity with Dimension or std::vector<int> objects as appropriate. In addition to eliminating manual memory management and making the code more readable, easy access to Dimension objects will allow for a subsequent PR to construct Matrix objects directly, replacing the current block_matrix representation of objects.

This is PR 2 in an ongoing series to make ccdensity compatible with the standard Matrix and Wavefunction machinery used elsewhere in Psi. Obligatory @lothian notification.

Checklist

  • cc tests still pass

Status

  • Ready for review
  • Ready for merge - to be explicit, Lori advised me not to merge until I had manually checked the cc tests, since those tests run by perl script

@JonathonMisiewicz JonathonMisiewicz added cc For all issues involving the CC module, ground-state energies to response properties. cleanup For issues where the goal is to make Psi4 a little cleaner. labels Feb 12, 2022
@JonathonMisiewicz JonathonMisiewicz added this to the Psi4 1.6 milestone Feb 12, 2022
lothian
lothian approved these changes Feb 13, 2022
View reviewed changes
Copy link
Contributor

@lothian lothian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@JonathonMisiewicz JonathonMisiewicz merged commit a30fed0 into psi4:master Feb 14, 2022
@JonathonMisiewicz JonathonMisiewicz deleted the ccdensity_fix branch February 14, 2022 15:02
zachglick pushed a commit to zachglick/psi4 that referenced this pull request Apr 18, 2022
@JonathonMisiewicz @zachglick
Lose stars (psi4#2438)
832228f 
`int *` to `std::vector<int>` and `Dimension`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxscheurer maxscheurer maxscheurer approved these changes

@lothian lothian lothian approved these changes

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
cc For all issues involving the CC module, ground-state energies to response properties. cleanup For issues where the goal is to make Psi4 a little cleaner.
Projects
None yet
Milestone
Psi4 1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@JonathonMisiewicz @loriab @lothian @maxscheurer