Clean libmints new/delete
#2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterKraus
reviewed
Nov 8, 2021
susilehtola
reviewed
Nov 8, 2021
jturney
approved these changes
Nov 9, 2021
|
Yeah, using valgrind will make it easier to find the leak. At one point, we did have it leak free. |
Good to know. Unfortunately, it may be a bit before I can get valgrind working - there are some issues with Francesco's cluster. |
loriab
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a memory leak somewhere in the SCF code. This PR replaces some of the manual memory management with
new/deleteinlibmintsto cut down the number of places where it could be coming from. (I'd like to start from a zero-leak baseline for DIIS profiling.)I'll probably need to use
valgrindto track this down further...Checklist
Status