-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue triage documentation #2236
Conversation
A dump of all of my knowledge in this space :) This should hopefully make it easier for newer contributors to take on the neverending work of issue triage.
+ and also add the missed Pipfile aiohttp-cors modification
I had a read, and the docs seem very thourough to me. And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Left some notes
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
I'm assuming we're getting ready for a new release soon since this was merged without resolving all of Jelle's suggestions. Don't worry, I'll add them after, but TBH a bit surprised 😕 Oh and I just got up so that's why I was unable to resolve them before. |
@ichard26 I'm adding them in a separate commit because the GitHub editor was clunky for this due to long lines. |
Fair enough, I guess a difference in workflows then since I do all documentation work locally (even with suggestions usually) so I don't mind tricky suggestions. Thank you though! |
A dump of all of my knowledge in this space :) This should hopefully make it easier for newer contributors to take on the neverending work of issue triage. Also add sphinx-copybutton so our code blocks are easily copiable and also add the missed Pipfile aiohttp-cors modification
Preview available here: https://ichard26-testblackdocs.readthedocs.io/en/issue-triage-docs/contributing/issue_triage.html
cc @cooperlees I added my saved replies thanks to your idea!