-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention in docs that int formatting only adds underscores above 10000 #546
Comments
underyx
changed the title
Mention in docs that into formatting only adds underscores above 10000
Mention in docs that int formatting only adds underscores above 10000
Oct 2, 2018
Yes, we should make the docs clearer on this. Wanna put up a pr?
…On Tue, Oct 2, 2018, 08:35 Bence Nagy ***@***.***> wrote:
Just spent a while looking for this info to give some teammates peace of
mind that we won't start seeing 2_018, 1_024, and so on. I had to read the
code to find out when underscores are added, which is not catastrophic, but
not ideal either
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#546>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEtLu_7ACWIj8-AXabxNAFGzpEw9OOks5ugxdNgaJpZM4XDetJ>
.
|
I could, yep! Opened the issue from my phone so I couldn't do it then. I saw some discussions about the logic and now it seems more complex than 'above 10000' though. Could you describe what rules I should document? |
For integers longer than 5 digits, underscores are used. For floats, this rule applies to both sides of the decimal point |
Not needed anymore, as the feature was removed due to #549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just spent a while looking for this info to give some teammates peace of mind that we won't start seeing 2_018, 1_024, and so on. I had to read the code to find out when underscores are added, which is not catastrophic, but not ideal either
The text was updated successfully, but these errors were encountered: