Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in docs that int formatting only adds underscores above 10000 #546

Closed
underyx opened this issue Oct 2, 2018 · 4 comments
Closed

Comments

@underyx
Copy link

underyx commented Oct 2, 2018

Just spent a while looking for this info to give some teammates peace of mind that we won't start seeing 2_018, 1_024, and so on. I had to read the code to find out when underscores are added, which is not catastrophic, but not ideal either

@underyx underyx changed the title Mention in docs that into formatting only adds underscores above 10000 Mention in docs that int formatting only adds underscores above 10000 Oct 2, 2018
@zsol
Copy link
Collaborator

zsol commented Oct 2, 2018 via email

@underyx
Copy link
Author

underyx commented Oct 3, 2018

I could, yep! Opened the issue from my phone so I couldn't do it then. I saw some discussions about the logic and now it seems more complex than 'above 10000' though. Could you describe what rules I should document?

@zsol
Copy link
Collaborator

zsol commented Oct 3, 2018

For integers longer than 5 digits, underscores are used. For floats, this rule applies to both sides of the decimal point

@underyx
Copy link
Author

underyx commented Mar 19, 2019

Not needed anymore, as the feature was removed due to #549

@underyx underyx closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants