-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github wf to add module labels for PR based on file changes #2
Conversation
For testing, we are using pull_request trigger. For apache/lucene repo, we would be using pull_request_target trigger. This is required for write access needed to add labels to PR. |
It seems that this would assign labels corresponding to different modules? I haven't seen such labels before, and I'm not sure if they are in active use, but it seems harmless and maybe useful to have them. I wonder if you could think of a way to assign a "milestone" label corresponding to the target branch of the commit? |
Yes, it assigns labels based on files they touch. We already had labels and requirement for this bot was raised here: apache#13897. I think it will be really useful. I'll think of a way to assign milestone label based on the branch. It is doable. |
ah, ok -- the basic idea is we want to label (issues? PRs? both?) with milestones corresponding to Lucene releases. I think milestone is a special github field that is not just a label, and I'm not sure if it can have multiple values. If it can have multiple values, I guess it should be tagged according to all the branches with which it is associated: otherwise (single-values) we want the value to be the lowest numbered release that includes a change. A wrinkle is that typically the release doesn't yet exist when the issue is created, so we need to infer what it is going to be. For example a change might be committed to branch_10x, but the milestone would be |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
1 similar comment
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Description
Testing adding labels to PR based on file changes.
Following files were changed:
.github/labeler.yml
.github/workflows/label-pull-request.yml
help/my_file.txt
lucene/analysis/my_file.txt
lucene/benchmark/my_file.txt
lucene/core/my_file.txt
lucene/core/src/java/org/apache/lucene/util/hnsw/my_file.txt
lucene/luke/my_file.txt
lucene/queryparser/my_file.txt