Merge Rquest #2
Merged
Merge Rquest #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.18.0 Changelog updates.
1.18.0 Changelog typo fix.
Adding #1210 to CHANGELOG.md
* Modernizr is a blocking script that has very little benefit for us. Removing this script improves page responsiveness. * We used Modernizr via the css classes `csscolumns`, `flexbox`, `objectfit`, and `js`. * The `csscolumns` class was used for productMasonry for older browsers, but since then all of our supported browsers support css columns. There is one small problem with Firefox: it does not support break-inside, but it does support page-break-inside, which does the same thing. See https://caniuse.com/#feat=multicolumn * The `flexbox` class is unused * The `objectfit` class is used by carousel. Reimplmented without using Modernizer. The previous implmentation put a background image on the wrapper div and then hid it if object-fit is supported. The new implementation does not put the background image on the wrapper div by default, but instead assumes that your browser supports object-fit (all ours do except for IE). For IE, we use javascript to copy the image source from the image tag to the background image of the wrapper div and then hide the image. * The `js` class is used for a few things in css, so mimic this behavior with a simple inline script.
* Add wrapper div for hero carousel that has the appropriate height for the image to be displayed after lazy loading. * This improves frontend performance because the browser will be less likely to load images below the fold immediately.
* Add dns prefetch & preconnect to core resources that we know we will need -- fonts, cdn, jirafe, etc
setting for skus. We were not properly switching back and forth
between skus that were above and below their own respective
threshholds.
fix(storefront): STRF-4875 Fix for sort query parameter with faceted search.
fix(storefront): STRF-4786 Do not escape blog summary HTML.
* Upgrade to webpack 4 * Clean up stencil bootstrap * Simplify interface for PageManager and get rid of async library dependency * Get rid of html5-history-api library dependency (no longer needed) * Get rid of fastclick library dependency (no longer needed) * Upgrade several babel dependencies * Separate webpack config into common, dev, prod, and add npm scripts to build * Get rid of minifications in babel loader, instead rely on webpack * Get rid of LoaderOptionsPlugin * Get rid of CommonsChunkPlugin (webpack 4 will automaticaly do this for prod)
* Use svg-injector to fetch the svg icon sprite rather than embed it directly on the page. This improves frontend performance because the icons will be cached after the first request and we reduce the page weight by about 28kb. * Move location of generated svg so it is retrievable by the frontend through the CDN. * Update svgstore grunt task
* Reduce the default number of featured, new, and bestselling products on the home page. * These can always be updated in Theme Editor, but the defaults don't need to be so high.
* Use laziest possible setting for images
* Use `resourceHints` helper from paper 2.0.8, which looks up configured cdn and font providers.
Cornerstone 2.0: Performance improvements
fix(storefront): STRF-4804 Fix Store Logo image size for Amp Pages
…and moving some tags to the appropriate div
fix(storefront): STRF-2456 Fixing Schema Org meta tags
Only show review tab when there are reviews.
Fix blog_post import statement in app.js
show dots only if carousel has more than one slide
change css for product productCarousel -> slick-track
Corrects mini cart display issues
Changelog for #1290
…a-attributes Fix initial aria attributes for 'Customers Also Viewed' products tab
Fix for the fix for review tabs.
fix(catalog): MERC-3743 Fix zoom behavior for small images in gallery
Undo New Products left align from 2.3.0.
change src for invoice logo image
Moved #1326 changelog entry to Draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to fix the navigation active issue in cornerstone and i want to work in latest cornerstone theme.