Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use orchestra/testbench-core as testbench should only be used for Package development #359

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Use orchestra/testbench-core as testbench should only be used for Package development #359

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4e6dae
wip
crynobone Nov 16, 2023
0a6ec7a
wip
crynobone Nov 16, 2023
4173ab5
wip
crynobone Nov 16, 2023
e4ee0a0
Merge branch 'master' into testbench-core
alies-dev Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"php": "^8.0.2",
"ext-simplexml": "*",
"barryvdh/laravel-ide-helper": "^2.13",
"fakerphp/faker": "^1.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find places where we use Faker on this package. Do you know them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm-plugin-laravel/stubs/legacy-factories/FactoryBuilder.stubphp

Line 5 in edc45c0

use Faker\Generator as Faker;

"illuminate/config": "^9.48 || ^10.0",
"illuminate/container": "^9.48 || ^10.0",
"illuminate/contracts": "^9.48 || ^10.0",
Expand All @@ -24,7 +25,7 @@
"illuminate/support": "^9.48 || ^10.0",
"illuminate/view": "^9.48 || ^10.0",
"nikic/php-parser": "^4.13",
"orchestra/testbench": "^7.19 || ^8.0",
"orchestra/testbench-core": "^7.35 || ^8.15",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^7.35 || ^8.15"

Do these versions contain for required functionality, or are they just to enforce new versions?

Note, this plugin built to support old versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both versions contain conflict restrictions (using composer.json) to ensure Testbench Core 7 will only be used with Laravel 9 and Testbench Core 8 only used with Laravel 10.

"symfony/console": "^6.0",
"vimeo/psalm": "^4.30 || ^5.1"
},
Expand All @@ -34,6 +35,7 @@
"codeception/module-cli": "^2.0",
"codeception/module-filesystem": "^3.0",
"codeception/module-phpbrowser": "^3.0",
"laravel/framework": "^9.48 || ^10.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package is made to support both Laravel and Lumen. I'm not sure that require Laravel is a good idea.

Copy link
Contributor Author

@crynobone crynobone Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only require-dev deps. Previously was provided in require via orchestra/testbench.

So this actually improves support for Lumen.

"phpunit/phpunit": "^9.6 || ^10.0",
"ramsey/collection": "^1.3",
"slevomat/coding-standard": "^8.8",
Expand Down