Re-Add ioman return value of 64 bits. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97bb4cd to
c4a1e01
Compare
fjtrujy
reviewed
Dec 23, 2024
| #define IOMAN_RETURN_VALUE(val) ((void*)&my_ioman_retval_##val##_int) | ||
| #define IOMAN_RETURN_VALUE_S64(val) ((void*)&my_ioman_retval_##val##_s64) |
There was a problem hiding this comment.
But it is not being used, where do you want to use it?
|
Please creates description for what do you want to merge this PR |
|
Open PS2 Loader.
Obter o Outlook para Android<https://aka.ms/AAb9ysg>
________________________________
From: Francisco Javier Trujillo Mata ***@***.***>
Sent: Monday, December 23, 2024 2:44:52 PM
To: ps2dev/ps2sdk ***@***.***>
Cc: André Guilherme ***@***.***>; Author ***@***.***>
Subject: Re: [ps2dev/ps2sdk] Re-Add ioman return value of 64 bits. (PR #703)
@fjtrujy commented on this pull request.
________________________________
In iop/system/ioman/include/ioman.h<#703 (comment)>:
#define IOMAN_RETURN_VALUE(val) ((void*)&my_ioman_retval_##val##_int)
+#define IOMAN_RETURN_VALUE_S64(val) ((void*)&my_ioman_retval_##val##_s64)
But it is not being used, where do you want to use it?
—
Reply to this email directly, view it on GitHub<#703 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASC2KXR5DXPZSTSNRB54XPD2HBDZJAVCNFSM6AAAAABT6Y3IESVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRQHE3DEOJVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Can you purpose another way or what?
Obter o Outlook para Android<https://aka.ms/AAb9ysg>
________________________________
From: André Guilherme ***@***.***>
Sent: Monday, December 23, 2024 2:45:33 PM
To: ps2dev/ps2sdk ***@***.***>; ps2dev/ps2sdk ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [ps2dev/ps2sdk] Re-Add ioman return value of 64 bits. (PR #703)
Open PS2 Loader.
Obter o Outlook para Android<https://aka.ms/AAb9ysg>
________________________________
From: Francisco Javier Trujillo Mata ***@***.***>
Sent: Monday, December 23, 2024 2:44:52 PM
To: ps2dev/ps2sdk ***@***.***>
Cc: André Guilherme ***@***.***>; Author ***@***.***>
Subject: Re: [ps2dev/ps2sdk] Re-Add ioman return value of 64 bits. (PR #703)
@fjtrujy commented on this pull request.
________________________________
In iop/system/ioman/include/ioman.h<#703 (comment)>:
#define IOMAN_RETURN_VALUE(val) ((void*)&my_ioman_retval_##val##_int)
+#define IOMAN_RETURN_VALUE_S64(val) ((void*)&my_ioman_retval_##val##_s64)
But it is not being used, where do you want to use it?
—
Reply to this email directly, view it on GitHub<#703 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASC2KXR5DXPZSTSNRB54XPD2HBDZJAVCNFSM6AAAAABT6Y3IESVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRQHE3DEOJVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Should use |
|
Please @uyjulian take care of this PR as you are more aware than me about this. |
Doesn't work on opl they used to a custom implementation of ioman to do cdvdman stuff, Well i think there is might be a way to remove that custom structure and add ps2sdk standard |
|
Thx, But tommorow i will test removing the custom structure from cdvdman if doesn´t work then i use the ioman stuff. Btw this should stay if appear another function which contains 64 bit values. So this come in handy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.