Add PeerDAS Feature Flag #13865
Merged
Add PeerDAS Feature Flag #13865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,6 +256,12 @@ func ConfigureBeaconChain(ctx *cli.Context) error { | |||
| logEnabled(BlobSaveFsync) | |||
| cfg.BlobSaveFsync = true | |||
| } | |||
| // For the p.o.c we enable it by default. | |||
| cfg.EnablePeerDAS = true | |||
There was a problem hiding this comment.
Might want to be careful with this one. Don't merge everything to develop later thinking it's feature-flag gated but forget this line still exists.
There was a problem hiding this comment.
Oh yeah definitely, in any case even if we merge to develop a node with this enabled will immediately stall since all the topics are non-existent in mainnet or any of the testnets
nalepae
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR implements a feature flag so that all peer das related changes to core code can be put behind a flag. Doing this allows us to be able to experiment on this in an easier fashion along with making this much simpler to modify for any future forks.
Which issues(s) does this PR fix?
N.A
Other notes for review