This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Convert to bazel managed dependencies #6
Assignees
Comments
|
Mostly done in #7 |
rauljordan
pushed a commit
that referenced
this issue
Apr 5, 2019
* added tests for new abi encoding features (#4) * added tests from bytes32[][] and string[] * added offset to other types * formatting * Abi/dynamic types (#5) * Revert "Abi/dynamic types (#5)" (#6) This reverts commit dabca31d797623d43bd780721fc0ad461d24be53. * Abi/dynamic types (#7) * some cleanup * Apply suggestions from code review apply suggestions Co-Authored-By: vedhavyas <vedhavyas.singareddi@gmail.com> * added better formatting (#8) * review chnages * better comments
|
Closing this as its been done as of: df74fa9 |
rauljordan
pushed a commit
that referenced
this issue
Apr 19, 2021
* internal/build: implement signify's signing func * Add signify to the ci utility * fix output file format * Add unit test for signify * holiman's + travis' feedback * internal/build: verify signify's output * crypto: move signify to common dir * use go-minisign to verify binaries * more holiman feedback * crypto, ci: support minisign output * only accept one-line trusted comments * configurable untrusted comments * code cleanup in tests * revert to use ed25519 from the stdlib * bug: fix for empty untrusted comments * write timestamp as comment if trusted comment isn't present * rename line checker to commentHasManyLines * crypto: added signify fuzzer (#6) * crypto: added signify fuzzer * stuff * crypto: updated signify fuzzer to fuzz comments * crypto: repro signify crashes * rebased fuzzer on build-signify branch * hide fuzzer behind gofuzz build flag * extract key data inside a single function * don't treat \r as a newline * travis: fix signing command line * do not use an external binary in tests * crypto: move signify to crypto/signify * travis: fix formatting issue * ci: fix linter build after package move Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
bazel-go-ethereum should attempt to load bazel dependencies, if they are not already present.
This would be a "maybe" type rule where the downstream client would load this library and call
The
go_ethereum_repositoriesrule will load any repository necessary to build go-ethereum which is not already installed. What we are seeing is that there are mixed versions of the same library in our downstream client which leads to wasted/redundant work.The text was updated successfully, but these errors were encountered: