Retarget SDK to upstream Go toolchain 1.24 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This reverts commit 33c01aa. Signed-off-by: Matt Leon <mattleon@google.com>
This reverts commit f4829de. Signed-off-by: Matt Leon <mattleon@google.com>
This reverts commit cbcb260. Signed-off-by: Matt Leon <mattleon@google.com>
)" This reverts commit 1d2249f. Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
12946c4 to
0a14044
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
martijneken
reviewed
Dec 17, 2024
martijneken
reviewed
Dec 17, 2024
martijneken
reviewed
Dec 17, 2024
martijneken
reviewed
Dec 18, 2024
Signed-off-by: Matt Leon <mattleon@google.com>
- Add CLA and community guidelines to CONTRIBUTING.md - Rename workflows - Remove e2e tests from workflows - Clarify difference from tetratelabs/proxy-wasm-go-sdk Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
9e3511e to
3599270
Compare
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
|
CI passes on my fork: https://github.com/leonm1/proxy-wasm-go-sdk/actions/runs/12401314220 |
martijneken
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK to use the upstream Go toolchain rather than the TinyGo toolchain as used by https://github.com/tetratelabs/proxy-wasm-go-sdk.
It restores and updates the readme, tests, and documentation, as well as adapting the SDK to the upstream toolchain's conventions for the host<->wasm interface.
This PR relies on changes to the cpp host in proxy-wasm/proxy-wasm-cpp-host#427 to be able to be used in proxy-wasm host environments.