Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genutil for sdk 50 #1925

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Update genutil for sdk 50 #1925

merged 8 commits into from
Apr 16, 2024

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Apr 11, 2024

Description

Adds genutil and includes minor fix to allow run-config and run to work again.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • New Features
    • Updated the SDK to version 0.50.5-pio-1 for improved performance and compatibility.
    • Enhanced application initialization process with updated configurations and dependencies.
  • Refactor
    • Streamlined genesis file creation and export functionality for better efficiency.
    • Improved command functions with additional validation and encoding features.
  • Chores
    • Removed unused navigation elements to simplify the user interface.

@Taztingo Taztingo requested a review from a team as a code owner April 11, 2024 20:32
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Warning

Rate Limit Exceeded

@Taztingo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 1 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 275bb96 and d164095.

Walkthrough

The changes focus on enhancing the genutil module for SDK 50, integrating RegisterStreamingServices in BaseApp, and advancing the SDK to v0.50.5-pio-1. Additionally, there are refinements in import paths and parameter handling in command initialization and root configuration files.

Changes

File Path Change Summary
CHANGELOG.md Updated genutil for SDK 50, implemented RegisterStreamingServices, upgraded SDK to v0.50.5-pio-1, removed unused navs.
cmd/provenanced/cmd/init.go Updated import path from govtypesv1beta1 to govtypesv1, modified govGenState.DepositParams.MinDeposit to govGenState.Params.MinDeposit.
cmd/provenanced/cmd/root.go Added genutiltypes import, updated genutilcli.CollectGenTxsCmd and genutilcli.GenTxCmd with new parameters for message validation and encoding.

Poem

🐇🌟
In the realm of code, where the bits do play,
A rabbit weaved updates in a delightful array.
With a tap and a tweak, and a sprinkle of cheer,
Farewell old quirks, for progress is near!
Hop, hop, hooray, let's rejoice in this state,
For the digital garden looks ever so great! 🌼🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

SpicyLemon
SpicyLemon previously approved these changes Apr 11, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

cmd/provenanced/cmd/init.go Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (4)
CHANGELOG.md (4)

Line range hint 61-68: Convert dash list markers to asterisk for consistency in Markdown list style.

- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
- - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).
+ * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
+ * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922).

Line range hint 137-160: Convert dash list markers to asterisk for consistency in Markdown list style.

- - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
- - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
- - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
- - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
- - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760).
+ * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897).
+ * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905).
+ * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920).
+ * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760).

Line range hint 197-199: Convert dash list markers to asterisk for consistency in Markdown list style.

- - Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.0 ([#1910](https://github.com/provenance-io/provenance/pull/1910))
- - Bump `google.golang.org/grpc` from 1.62.1 to 1.63.2 ([#1903](https://github.com/provenance-io/provenance/pull/1903), [#1918](https://github.com/provenance-io/provenance/pull/1918))
- - Bump `bufbuild/buf-breaking-action` from 1.1.3 to 1.1.4 ([#1894](https://github.com/provenance-io/provenance/pull/1894))
+ * Bump `github.com/cosmos/ibc-go/v8` from 8.0.0 to 8.2.0 ([#1910](https://github.com/provenance-io/provenance/pull/1910))
+ * Bump `google.golang.org/grpc` from 1.62.1 to 1.63.2 ([#1903](https://github.com/provenance-io/provenance/pull/1903), [#1918](https://github.com/provenance-io/provenance/pull/1918))
+ * Bump `bufbuild/buf-breaking-action` from 1.1.3 to 1.1.4 ([#1894](https://github.com/provenance-io/provenance/pull/1894))

Line range hint 276-298: Convert dash list markers to asterisk for consistency in Markdown list style.

- - Bump `bufbuild/buf-lint-action` from 1.1.0 to 1.1.1 ([#1895](https://github.com/provenance-io/provenance/pull/1895))
- - Bump `bufbuild/buf-setup-action` from 1.30.0 to 1.30.1 ([#1904](https://github.com/provenance-io/provenance/pull/1904))
- - Bump `github.com/cometbft/cometbft` from 0.38.5 to 0.38.6 ([#1912](https://github.com/provenance-io/provenance/pull/1912))
- - Bump `cosmossdk.io/x/upgrade` from 0.1.0 to 0.1.1 ([#1913](https://github.com/provenance-io/provenance/pull/1913))
- - Bump `github.com/hashicorp/go-metrics` from 0.5.2 to 0.5.3 ([#1914](https://github.com/provenance-io/provenance/pull/1914))
+ * Bump `bufbuild/buf-lint-action` from 1.1.0 to 1.1.1 ([#1895](https://github.com/provenance-io/provenance/pull/1895))
+ * Bump `bufbuild/buf-setup-action` from 1.30.0 to 1.30.1 ([#1904](https://github.com/provenance-io/provenance/pull/1904))
+ * Bump `github.com/cometbft/cometbft` from 0.38.5 to 0.38.6 ([#1912](https://github.com/provenance-io/provenance/pull/1912))
+ * Bump `cosmossdk.io/x/upgrade` from 0.1.0 to 0.1.1 ([#1913](https://github.com/provenance-io/provenance/pull/1913))
+ * Bump `github.com/hashicorp/go-metrics` from 0.5.2 to 0.5.3 ([#1914](https://github.com/provenance-io/provenance/pull/1914))

@Taztingo Taztingo enabled auto-merge (squash) April 12, 2024 18:40
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (4)
CHANGELOG.md (4)

Line range hint 62-299: Consider using a consistent list marker style in markdown.

- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
+ * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).

Line range hint 173-594: Convert bare URLs to markdown links for better readability.

- https://github.com/provenance-io/provenance/issues/1772
+ [Issue #1772](https://github.com/provenance-io/provenance/issues/1772)

Line range hint 762-1336: Remove extra blank lines to maintain a clean and consistent format.

-

Line range hint 286-890: Correct the markdown syntax by removing unnecessary spaces inside emphasis and code span elements.

- ` v0.50.2 `
+ `v0.50.2`

@Taztingo Taztingo disabled auto-merge April 15, 2024 19:36
SpicyLemon
SpicyLemon previously approved these changes Apr 15, 2024
…Set initial config as testnet that will be overwritten by start.
@Taztingo Taztingo dismissed stale reviews from SpicyLemon and nullpointer0x00 via a258da6 April 16, 2024 13:48
@Taztingo Taztingo enabled auto-merge (squash) April 16, 2024 14:02
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
CHANGELOG.md (1)

Line range hint 64-300: Consistency in list item markers.

Please use asterisks (*) instead of dashes (-) for list items to maintain consistency throughout the document.

- -
+ *

CHANGELOG.md Outdated Show resolved Hide resolved
@Taztingo Taztingo requested a review from SpicyLemon April 16, 2024 18:25
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md Outdated Show resolved Hide resolved
SpicyLemon
SpicyLemon previously approved these changes Apr 16, 2024
@Taztingo Taztingo merged commit 8256904 into main Apr 16, 2024
19 of 36 checks passed
@Taztingo Taztingo deleted the taztingo/1760-genutil branch April 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants