Code

Dwedul/1699 exchange keeper tests#1713

Code

Merged

iramiller merged 112 commits intomainprovenance-io/provenance:mainfrom dwedul/1699-exchange-keeper-testsprovenance-io/provenance:dwedul/1699-exchange-keeper-testsCopy head branch name to clipboardNov 1, 2023

+20,619-521

Commits

Commits on Oct 18, 2023

• [1699]: Unit tests on params.

  SpicyLemon

  committed
  c051276

  Copy full SHA for c051276

• [1699]: Unit tests on the flat fee getters.

  SpicyLemon

  committed
  cd2bf81

  Copy full SHA for cd2bf81

• [1699]: Unit tests on the ratio fee getters and calculators.

  SpicyLemon

  committed
  5fadb5f

  Copy full SHA for 5fadb5f

• [1699]: Unit tests on the flat fee validators.

  SpicyLemon

  committed
  0b6d733

  Copy full SHA for 0b6d733

• [1699]: Unit tests on ValidateAskPrice.

  SpicyLemon

  committed
  6ae52a1

  Copy full SHA for 6ae52a1

• [1699]: Change TestSuite.ratio to use ParseFeeRatio.

  SpicyLemon

  committed
  55ff8d8

  Copy full SHA for 55ff8d8

• [1699]: Unit tests on ValidateBuyerSettlementFee.

  SpicyLemon

  committed
  903ab16

  Copy full SHA for 903ab16

• [1699]: Unit tests on UpdateFees.

  SpicyLemon

  committed
  700a272

  Copy full SHA for 700a272

• [1699]: Create Keeper.IsMarketKnown and tweak the comments on IsMarketActive.

  SpicyLemon

  committed
  c9a9539

  Copy full SHA for c9a9539

• [1699]: Unit tests on IsMarketKnown and IsMarketActive.

  SpicyLemon

  committed
  49d2d5e

  Copy full SHA for 49d2d5e

• [1699]: Unit tests on UpdateMarketActive.

  SpicyLemon

  committed
  5665ab5

  Copy full SHA for 5665ab5

• [1699]: Unit tests 0on IsUserSettlementAllowed and UpdateUserSettlementAllowed.

  SpicyLemon

  committed
  31da371

  Copy full SHA for 31da371

• [1699]: Unit tests on HasPermission and each of the specific Can... permission checkers.

  SpicyLemon

  committed
  7069fb5

  Copy full SHA for 7069fb5

• Merge branch 'main' into dwedul/1699-exchange-keeper-tests

  SpicyLemon

  committed
  5b55161

  Copy full SHA for 5b55161

Commits on Oct 19, 2023

• [1699]: Fix getAccessGrants.

  SpicyLemon

  committed
  831ab5e

  Copy full SHA for 831ab5e

• [1699]: Unit tests on GetUserPermissions and GetAccessGrants.

  SpicyLemon

  committed
  4f8d7eb

  Copy full SHA for 4f8d7eb

• Merge branch 'main' into dwedul/1699-exchange-keeper-tests

  SpicyLemon

  committed
  2096280

  Copy full SHA for 2096280

• [1699]: Unit tests on UpdatePermissions.

  SpicyLemon

  committed
  f5fe101

  Copy full SHA for f5fe101

• [1699]: Unit tests on GetReqAttrsAsk, GetReqAttrsBid, CanCreateAsk, and CanCreateBid.

  SpicyLemon

  committed
  a0b670f

  Copy full SHA for a0b670f

• [1699]: Make NewEventMarketPermissionsUpdated just take in the admin as a string since that's what we've got it as when we want to create that event.

  SpicyLemon

  committed
  b561010

  Copy full SHA for b561010

• [1699]: Make NewEventMarketReqAttrUpdated just take in the admin as a string since that's what we've got it as when we want to create that event.

  SpicyLemon

  committed
  26f581d

  Copy full SHA for 26f581d

• [1699]: Unit tests on UpdateReqAttrs.

  SpicyLemon

  committed
  bedd1da

  Copy full SHA for bedd1da

• [1699]: Unit tests on GetMarketAccount.

  SpicyLemon

  committed
  43a83aa

  Copy full SHA for 43a83aa

• [1699]: Unit tests on GetMarketDetails.

  SpicyLemon

  committed
  a46ebdf

  Copy full SHA for a46ebdf

• [1699]: Remove 'Calls' from the field names of the mock keeper ...Calls structs.

  SpicyLemon

  committed
  a5524b5

  Copy full SHA for a5524b5

• [1699]: Update NewEventMarketDetailsUpdated to take in a string since that's what we've already got it as everywhere.

  SpicyLemon

  committed
  c1072d4

  Copy full SHA for c1072d4

• [1699]: Update NewEventMarketActiveUpdated, NewEventMarketEnabled, and NewEventMarketDisabled to take in an updatedBy string (instead of AccAddress) since that's what we've already got it as anyway.

  SpicyLemon

  committed
  7fdaf06

  Copy full SHA for 7fdaf06

• [1699]: Change NewEventMarketWithdraw to take in withdrawnBy as a string since we don't need it as an addr anywhere.

  SpicyLemon

  committed
  90096a7

  Copy full SHA for 90096a7

• [1699]: Update NewEventMarketUserSettleUpdated, NewEventMarketUserSettleEnabled, and NewEventMarketUserSettleDisabled to take in updatedBy as a string.

  SpicyLemon

  committed
  3bd8877

  Copy full SHA for 3bd8877

• [1699]: Update exchange.NewEventOrderCancelled to take in cancelledBy as a string.

  SpicyLemon

  committed
  0f383a6

  Copy full SHA for 0f383a6

• [1699]: A little cleanup in TestTypedEventToEvent.

  SpicyLemon

  committed
  e071e75

  Copy full SHA for e071e75

• [1699]: Unit tests on UpdateMarketDetails.

  SpicyLemon

  committed
  04c9168

  Copy full SHA for 04c9168

• [1699]: Change NewAccountResultsMap to NewAccountModifierMap and have NewAccount modify the provided account directly since that's how that func is used.

  SpicyLemon

  committed
  d0060c1

  Copy full SHA for d0060c1

• [1699]: Unit tests on CreateMarket.

  SpicyLemon

  committed
  5867b5d

  Copy full SHA for 5867b5d

Commits on Oct 20, 2023

• [1699]: Unit tests on GetMarket and IterateMarkets.

  SpicyLemon

  committed
  16af39f

  Copy full SHA for 16af39f

• [1699]: A little cleanup in TestKeeper_CreateMarket since I have SetAccount update the GetAccount results in the mock account keeper.

  SpicyLemon

  committed
  7bdd07b

  Copy full SHA for 7bdd07b

• [1699]: Unit tests on GetMarketBrief.

  SpicyLemon

  committed
  9427087

  Copy full SHA for 9427087

• [1699]: Unit tests on WithdrawMarketFunds.

  SpicyLemon

  committed
  ca912f1

  Copy full SHA for ca912f1

• [1699]: Unit tests on ValidateMarket.

  SpicyLemon

  committed
  1442a3f

  Copy full SHA for 1442a3f

• [1699]: Clean up the market unit tests by not passing the *TestSuite around needlessly.

  SpicyLemon

  committed
  70f27c0

  Copy full SHA for 70f27c0

• [1699] Unit tests on GetOrder.

  SpicyLemon

  committed
  bde70b1

  Copy full SHA for bde70b1

• [1699]: Unit tests on GetOrderByExternalID.

  SpicyLemon

  committed
  d2364cb

  Copy full SHA for d2364cb

• [1699]: Fix setOrderInStore to check the store correctly for an existing external id.

  SpicyLemon

  committed
  ff07d5f

  Copy full SHA for ff07d5f

• [1699]: Add IsReqAttrMatch unit test case.

  SpicyLemon

  committed
  045e7a5

  Copy full SHA for 045e7a5

• [1699]: Unit tests on CreateAskOrder and CreateBidOrder.

  SpicyLemon

  committed
  d631b81

  Copy full SHA for d631b81

• [1699]: Unit tests on CancelOrder.

  SpicyLemon

  committed
  ecef7aa

  Copy full SHA for ecef7aa

• [1699]: Unit tests on SetOrderExternalID.

  SpicyLemon

  committed
  64b0c84

  Copy full SHA for 64b0c84

• [1699]: In parseOrderStoreKeyValue, include the failed order id when it's available.

  SpicyLemon

  committed
  3677641

  Copy full SHA for 3677641

• [1699]: Unit tests on IterateOrders.

  SpicyLemon

  committed
  0bd00ad

  Copy full SHA for 0bd00ad

Commits on Oct 21, 2023

• [1699]: Unit tests on IterateMarketOrders, IterateAddressOrders, and IterateAssetOrders.

  SpicyLemon

  committed
  4fecabd

  Copy full SHA for 4fecabd

Commits on Oct 23, 2023

• [1699]: In InitGenesis, ensure that the last order id is at least the largest order id, and include the hold error in the returned error.

  SpicyLemon

  committed
  66a0d8a

  Copy full SHA for 66a0d8a

• [1699]: Unit tests on InitGenesis and ExportGenesis.

  SpicyLemon

  committed
  54e9f5f

  Copy full SHA for 54e9f5f

• [1699]: Create expEvents using var instead of empty slice since assertEqualEvents doesn't care about nil vs empty. Call assertEqualEvents in TestKeeper_SetOrderExternalID.

  SpicyLemon

  committed
  b4303c5

  Copy full SHA for b4303c5

• [1699]: Unit tests on FillBids.

  SpicyLemon

  committed
  247dc14

  Copy full SHA for 247dc14

Commits on Oct 24, 2023

• [1699]: Unit tests on FillAsks.

  SpicyLemon

  committed
  2fee16d

  Copy full SHA for 2fee16d

• [1699]: Unit tests on SettleOrders.

  SpicyLemon

  committed
  6a3c196

  Copy full SHA for 6a3c196

• [1699]: Take the stdlibCtx out of the TestSuite and delete the unused int and intStr methods. Replace assertErrorContents with assertErrorContentsf.

  SpicyLemon

  committed
  5d9fb97

  Copy full SHA for 5d9fb97

• [1699]: In OrderFeeCalc, return an error if the market does not exist.

  SpicyLemon

  committed
  385cc52

  Copy full SHA for 385cc52

• [1699]: Unit tests on the OrderFeeCalc query.

  SpicyLemon

  committed
  e4928cc

  Copy full SHA for e4928cc

• [1699]: In GetOrderByExternalID, return an error if either the market is zero or no external id is given.

  SpicyLemon

  committed
  d8c0ca7

  Copy full SHA for d8c0ca7

• [1699]: Unit tests on GetOrder and GetOrderByExternalID.

  SpicyLemon

  committed
  cfd6130

  Copy full SHA for cfd6130

Commits on Oct 25, 2023

• [1699]: Fix the order index queries to properly get the orders.

  SpicyLemon

  committed
  5b8b646

  Copy full SHA for 5b8b646

• [1699]: Modify filteredPaginateAfterOrder with key to return a NextKey that's a hit instead of just the next key the iterator sees. This way, it matches the NextKey behavior when using Offset instead.

  SpicyLemon

  committed
  92ff222

  Copy full SHA for 92ff222

• [1699]: In getOrderIterator, for the reverse iterator, the 'start' orderID should be one more than the afterOrderID.

  SpicyLemon

  committed
  2e5d254

  Copy full SHA for 2e5d254

• [1699]: Unit tests on the GetMarketOrders query.

  SpicyLemon

  committed
  76d477d

  Copy full SHA for 76d477d

• [1699]: Include the invalid owner in the error from GetOwnerOrders.

  SpicyLemon

  committed
  1e57227

  Copy full SHA for 1e57227

• [1699]: Unit tests on the GetOwnerOrders query.

  SpicyLemon

  committed
  c7bfdc9

  Copy full SHA for c7bfdc9

• [1699]: Unit tests on the GetAssetOrders query.

  SpicyLemon

  committed
  f021726

  Copy full SHA for f021726

• [1699]: Add a unit test on each of the order iterator queries for a case when the page request is invalid.

  SpicyLemon

  committed
  09c2d53

  Copy full SHA for 09c2d53

• [1699]: Fix GetAllOrders.

  SpicyLemon

  committed
  d119d35

  Copy full SHA for d119d35

• [1699]: Unit tests on GetAllOrders.

  SpicyLemon

  committed
  d5d0d19

  Copy full SHA for d5d0d19

• [1699]: Change the querySetupFunc to not take in the context, and just do a swaparoo on the context in the test suite.

  SpicyLemon

  committed
  50d26b4

  Copy full SHA for 50d26b4

• [1699]: Set the address in the QueryGetMarketResponse.

  SpicyLemon

  committed
  9252364

  Copy full SHA for 9252364

• [1699]: Unit tests on the GetMarket query. Create requireCreateMarketUnmocked and use that everywhere in the query tests.

  SpicyLemon

  committed
  464e1dc

  Copy full SHA for 464e1dc

• [1699]: Unit tests on the GetAllMarkets query.

  SpicyLemon

  committed
  349a14b

  Copy full SHA for 349a14b

• [1699]: Unit tests on the Params query.

  SpicyLemon

  committed
  cbd542e

  Copy full SHA for cbd542e

• [1699]: Unit tests on the ValidateCreateMarket query.

  SpicyLemon

  committed
  7ff1549

  Copy full SHA for 7ff1549

• [1699]: Unit tests on the ValidateMarket query.

  SpicyLemon

  committed
  d92ea10

  Copy full SHA for d92ea10

• [1699]: Unit tests on the ValidateManageFees query.

  SpicyLemon

  committed
  68e2e2c

  Copy full SHA for 68e2e2c

Commits on Oct 26, 2023

• [1699]: Remove todo about discussing the DefaultDefaultSplit value. Best consensus was that 5% seems alright until we know better.

  SpicyLemon

  committed
  638e948

  Copy full SHA for 638e948

• [1699]: Comment change on the querySetupFunc definition.

  SpicyLemon

  committed
  eedf1b6

  Copy full SHA for eedf1b6

Commits on Oct 27, 2023

• [1699]: Unit tests on the CreateAsk and CreateBid endpoints.

  SpicyLemon

  committed
  58b93d1

  Copy full SHA for 58b93d1

• [1699]: Unit tests on the CancelOrder endpoint.

  SpicyLemon

  committed
  e21dc85

  Copy full SHA for e21dc85

• [1699]: change IsMarketActive to only return true if the market is both known and active.

  SpicyLemon

  committed
  72162fb

  Copy full SHA for 72162fb

• [1699]: Add saffron-rc2 no-op upgrade entry.

  SpicyLemon

  committed
  901c5e9

  Copy full SHA for 901c5e9

• [1699]: In FillBids, calculate the seller settlement ratio fee off the total price instead of each order individually.

  SpicyLemon

  committed
  13bbd81

  Copy full SHA for 13bbd81

• [1699]: Unit tests on FillBids. Extract the balance checking stuff so it's easier for several tests to use.

  SpicyLemon

  committed
  89a367f

  Copy full SHA for 89a367f

• [1699]: Unit tests on FillAsks.

  SpicyLemon

  committed
  31c8f2a

  Copy full SHA for 31c8f2a

• [1699]: Unit tests on the MarketSettle endpoint.

  SpicyLemon

  committed
  74f122a

  Copy full SHA for 74f122a

• [1699]: Fix error message from MarketSetOrderExternalID when admin doesn't have permission since they might not actually be uuids.

  SpicyLemon

  committed
  25bf391

  Copy full SHA for 25bf391

• [1699]: Unit tests on the MarketSetOrderExternalID endpoint.

  SpicyLemon

  committed
  4a8f0a7

  Copy full SHA for 4a8f0a7

Commits on Oct 28, 2023

• [1699] Unit tests on the MarketWithdraw endpoint.

  SpicyLemon

  committed
  b3c86c2

  Copy full SHA for b3c86c2

• [1699]: Unit tests on the MarketUpdateDetails endpoint. Replace uses of requireCreateMarket in the msg_server_test file (with requireCreateMarketUnmocked).

  SpicyLemon

  committed
  53e906c

  Copy full SHA for 53e906c

• [1699]: Unit tests on the MarketUpdateEnabled and MarketUpdateUserSettle endpoints.

  SpicyLemon

  committed
  7e1ba22

  Copy full SHA for 7e1ba22

• [1699]: Unit tests on the MarketManagePermissions and MarketManageReqAttrs endpoints.

  SpicyLemon

  committed
  afea6c0

  Copy full SHA for afea6c0

• [1699]: Unit tests on the GovCreateMarket, GovManageFees, and GovUpdateParams endpoints. All done with tests.

  SpicyLemon

  committed
  33ca337

  Copy full SHA for 33ca337

• [1699]: Mark v1.17.0-rc1 in the changelog.

  SpicyLemon

  committed
  3bd1269

  Copy full SHA for 3bd1269

• [1699]: Add changelog entry.

  SpicyLemon

  committed
  8cf8c1d

  Copy full SHA for 8cf8c1d

Commits on Oct 30, 2023

• [1699]: clean up some of the expected event creation stuff.

  SpicyLemon

  committed
  63d9301

  Copy full SHA for 63d9301

• [1699]: Move all the generic keeper test helper funcs to a new suite_test.go file as well as the TestSuite definition. Do a little cleanup to use those in a few places where it made sense.

  SpicyLemon

  committed
  6ca98bb

  Copy full SHA for 6ca98bb

• [1699]: Remove some unneeded things from the TestSuite.

  SpicyLemon

  committed
  d612a4f

  Copy full SHA for d612a4f

• [1699]: Some comment clarifications.

  SpicyLemon

  committed
  957425b

  Copy full SHA for 957425b

• [1699]: Make TestSuite.badKey for changing a key into a bad version of it for the tests that want an incorrect key entry.

  SpicyLemon

  committed
  7117309

  Copy full SHA for 7117309

• [1699]: Do some of the market id comparisons as ints for better failure output.

  SpicyLemon

  committed
  a9b5010

  Copy full SHA for a9b5010

• [1699]: Refactor grpc_query_test to be similar to msg_server_test with the typed test definitions and test cases.

  SpicyLemon

  committed
  2e358e9

  Copy full SHA for 2e358e9

• [1699]: Add some test cases to the ValidateManageFees query where everything in the msg is okay, but results in a bad market setup.

  SpicyLemon

  committed
  4aa1a95

  Copy full SHA for 4aa1a95

• [1699]: Underscore some unused followup func arguments in msg_server_test.

  SpicyLemon

  committed
  ebf259c

  Copy full SHA for ebf259c

• [1699]: Create agCanOnly, agCanAllBut, and agCanEverything and use them in severl test cases where similar stuff was being done the hard way.

  SpicyLemon

  committed
  20820ad

  Copy full SHA for 20820ad

• [1699]: Clean up some of the follow-up args type defs.

  SpicyLemon

  committed
  a090bba

  Copy full SHA for a090bba

Commits on Oct 31, 2023

• Merge branch 'main' into dwedul/1699-exchange-keeper-tests

  SpicyLemon

  authored
  257a331

  Copy full SHA for 257a331

• Merge branch 'main' into dwedul/1699-exchange-keeper-tests

  SpicyLemon

  authored
  48c9693

  Copy full SHA for 48c9693

Commits on Nov 1, 2023

• Merge branch 'main' into dwedul/1699-exchange-keeper-tests

  iramiller

  authored
  7400d7e

  Copy full SHA for 7400d7e