Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify workflow to not append the run-number to latest docker tag #551

Merged

Conversation

nullpointer0x00
Copy link
Contributor

Description

This PR updates the Docker workflow to ensure that the latest tag in the Docker repository correctly represents the code from the main branch, removing the previous behavior of appending a run number to the tag (e.g., latest-<run-number>). The outdated latest tag was causing issues with ArgoCD, which was attempting to pull the most recent latest image but instead retrieved the outdated tag, leading to deployment problems.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 self-assigned this Sep 25, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review September 25, 2024 16:15
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner September 25, 2024 16:15
@nullpointer0x00 nullpointer0x00 merged commit 671b1a0 into main Sep 25, 2024
3 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/change-workflow-tagging-for-merge-to-main branch September 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants