forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in SDK changes up to v0.50.10 and Mark v0.50.10-pio-1. #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
…osmos#19751) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…mos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>
…9706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>
…9777) Co-authored-by: Julien Robert <julien@rbrt.fr>
…cosmos#19770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…osmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…mos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr>
…s#19884) Co-authored-by: Julien Robert <julien@rbrt.fr>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com>
…s#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
…s#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr>
…mos#20111) Co-authored-by: mmsqe <mavis@crypto.com>
…#21484) (cosmos#21493) Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…smos#21519) Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#21535) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#21544) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#21413) (cosmos#21541) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
…ample (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
…ckport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>
…osmos#21693) (cosmos#21724) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
…mos#21773) Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
…kport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Release v0.50.10 # -----BEGIN PGP SIGNATURE----- # # iHUEABYKAB0WIQQQT/CpGzc0x0Rg2OeuqMIeYI8dAgUCZu1V+QAKCRCuqMIeYI8d # AoRRAQDf1S3x/tE7c8ck9Nc/TjiPO0rGKZhHgcjPgO8z7C0u0wEAjcF5kX8QYAYL # iwMjoim+s85OgCb+7qb91hQgUFZLRQI= # =o4YU # -----END PGP SIGNATURE----- # gpg: Signature made Fri Sep 20 05:01:13 2024 MDT # gpg: using EDDSA key 104FF0A91B3734C74460D8E7AEA8C21E608F1D02 # gpg: Can't check signature: No public key # Conflicts: # CHANGELOG.md # RELEASE_NOTES.md # api/go.mod # api/go.sum # baseapp/baseapp.go # baseapp/options.go # client/rpc/tx.go # client/v2/CHANGELOG.md # client/v2/go.mod # client/v2/go.sum # core/go.mod # core/go.sum # docs/docs/build/building-apps/03-app-upgrade.md # go.mod # go.sum # orm/go.mod # orm/go.sum # runtime/builder.go # simapp/go.mod # simapp/go.sum # store/CHANGELOG.md # store/go.mod # store/go.sum # tests/go.mod # tests/go.sum # tools/confix/go.mod # tools/confix/go.sum # tools/cosmovisor/go.mod # tools/cosmovisor/go.sum # tools/hubl/go.mod # tools/hubl/go.sum # types/mempool/priority_nonce_test.go # x/bank/keeper/send.go # x/circuit/go.mod # x/circuit/go.sum # x/consensus/keeper/keeper.go # x/evidence/go.mod # x/evidence/go.sum # x/feegrant/go.mod # x/feegrant/go.sum # x/feegrant/module/module.go # x/nft/go.mod # x/nft/go.sum # x/simulation/simulate.go # x/tx/go.mod # x/tx/go.sum # x/upgrade/CHANGELOG.md # x/upgrade/go.mod # x/upgrade/go.sum
…his in PR cosmos#21460 and I undid it when merging in the v0.50.10 changes since it's more complicated for us than the SDK. So this is bringing us back in line with SDK v0.50.10 with slightly different event ordering. This change also reduces the amount of times subUnlockedCoins is called when there are multiple inputs with the same address.
I ran the following
|
8 tasks
iramiller
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in all of the SDK changes from (and including) v0.50.8, v0.50.9, and v0.50.10.
One change of note is to the events emitted during
InputOutputCoins
. The SDK added thesender
to thetransfer
events that are emitted. They can do that because they limit it to a singleinput
, so there's only ever one sender and it can be included in all of those events. However, ours allows for multiple inputs, so it's a little more complicated. The result, though, is that almost all transaction events that it emits will have all there ofrecipient
,sender
, andamount
, just like theSendCoins
events. The only way thesender
won't be there is if there are multipleinputs
(and oneoutput
), but when applying the send restrictions, the recipient is changed for at least one, but not all of the input addresses. E.g. The output address has opted into quarantine and has auto-accept enabled for one of the input addresses, but not the rest. I'm expecting that to be a super rare case though.Here are the places where I made changes on top of the SDK v0.50.10 changes:
AttributeKeySender
attribute to thetransfer
event, but ours took a little more work (as pointed out above).addCoins
event and thetransfer
event for each output address, so the event they're looking for is at index27
. But for us, we emit all theaddCoins
events, then all thetransfer
events, which ends up basically swapping event27
and28
in that test, so for us, we're expecting that event at28
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change