Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-pio/v0.46.xLlama incorporate pr feedback #356

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

llama-del-rey
Copy link

@llama-del-rey llama-del-rey commented Nov 10, 2022

Description

I merged #270. Danny provided some feedback. Incorporating it in here.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@llama-del-rey llama-del-rey marked this pull request as ready for review November 10, 2022 20:51
Copy link

@SpicyLemon SpicyLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing to fix, but the rest looks good!

x/bank/types/msgs_test.go Outdated Show resolved Hide resolved
@SpicyLemon SpicyLemon changed the base branch from release-pio/v0.46.x to main-pio November 15, 2022 18:51
Copy link

@SpicyLemon SpicyLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran make test locally, and they all passed!

I changed the target branch to main-pio. That branch has your original changes in it which have been reverted from the release-pio/v0.46.x branch.

@SpicyLemon SpicyLemon merged commit f0cfe13 into main-pio Nov 15, 2022
@SpicyLemon SpicyLemon deleted the llama-incorporate-pr-feedback branch December 17, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants