Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Topics: Do not send properties which are not defined explicitly #4097

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

p-eye
Copy link
Contributor

@p-eye p-eye commented Aug 7, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
although retention.bytes is from "Custom Parameter" when creating topic, it was declared directly in Form and Configs.
so the default value for retention.bytes didn't work.
after removed, retention.bytes works like other Custom Parameters.
Fixes #4030

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@p-eye p-eye requested a review from a team as a code owner August 7, 2023 06:38
@Haarolean Haarolean added type/bug Something isn't working scope/frontend labels Aug 11, 2023
@Haarolean Haarolean self-assigned this Aug 11, 2023
@Haarolean Haarolean changed the title fix: set 'retention.bytes' implicitly FE: Topics: Do not send properties which are not defined explicitly Aug 23, 2023
@Haarolean Haarolean merged commit 7a82079 into provectus:master Aug 23, 2023
@Haarolean
Copy link
Contributor

@p-eye thank you for the contribution. What about other params tho?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@p-eye
Copy link
Contributor Author

p-eye commented Aug 23, 2023

@Haarolean
because retention.bytes is one element of customParams, it didn't have to be declared.
but other params are not included in customParams list.
so when they are removed from the code, my explicit config values are not passed to backend. therefore i fixed only for retention.bytes.

thank you for your inspection

@p-eye p-eye deleted the issues/4030 branch August 26, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Topics: Do not send properties which are not defined explicitly
3 participants