Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Fix active controller badge on invalid node #4085

Merged
merged 4 commits into from
Aug 23, 2023
Merged

FE: Fix active controller badge on invalid node #4085

merged 4 commits into from
Aug 23, 2023

Conversation

moremagic
Copy link
Contributor

@moremagic moremagic commented Aug 3, 2023 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #3614

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@moremagic moremagic requested a review from a team as a code owner August 3, 2023 00:52
github-actions[bot]
github-actions bot reviewed Aug 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there moremagic! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean Haarolean self-assigned this Aug 3, 2023
@Haarolean Haarolean changed the title Fixes provectus/kafka-ui#3614 FE: Fix active controller badge on invalid node Aug 7, 2023
@Haarolean
Copy link
Contributor

@moremagic hey, can we add a test for this?

@Haarolean Haarolean self-requested a review August 7, 2023 14:12
@Haarolean Haarolean added type/bug Something isn't working scope/frontend labels Aug 7, 2023
@Haarolean Haarolean assigned moremagic and unassigned Haarolean Aug 7, 2023
@Haarolean Haarolean added the status/pending Further information is requested label Aug 10, 2023
@moremagic
Copy link
Contributor Author

@Haarolean I'll try for create test code.

@moremagic
Copy link
Contributor Author

Changed BrokerID in test data to avoid confusion with test case row index.
Changed relevant test cases.

@moremagic
Copy link
Contributor Author

@Haarolean

Added test. please check

@Haarolean Haarolean removed the status/pending Further information is requested label Aug 23, 2023
@Haarolean Haarolean assigned Haarolean and unassigned moremagic Aug 23, 2023
@Haarolean
Copy link
Contributor

@moremagic thank you very much!

@Haarolean Haarolean enabled auto-merge (squash) August 23, 2023 06:44
@Haarolean Haarolean added the status/pre-merge PRs ready to merge label Aug 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean merged commit cca2c96 into provectus:master Aug 23, 2023
gimral pushed a commit to gimral/kafka-ui that referenced this pull request Feb 23, 2024
@moremagic @Haarolean @gimral
FE: Fix active controller badge on invalid node (provectus#4085)
2f86cbc 
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Mgrdich Mgrdich Mgrdich approved these changes

@Haarolean Haarolean Awaiting requested review from Haarolean

Assignees

@Haarolean Haarolean

Labels
scope/frontend status/pre-merge PRs ready to merge type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Active controller badge on invalid node
3 participants
@moremagic @Haarolean @Mgrdich