Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed travis and added automated tests via github workflow #412

Merged
merged 6 commits into from
Feb 27, 2023
Merged

feat: removed travis and added automated tests via github workflow #412

merged 6 commits into from
Feb 27, 2023

Conversation

dbale-altoros
Copy link
Collaborator

No description provided.

@dbale-altoros dbale-altoros marked this pull request as draft February 21, 2023 18:57
@dbale-altoros dbale-altoros force-pushed the feat/add-github-action-to-test-repo branch 4 times, most recently from ca193df to d5083e0 Compare February 21, 2023 19:22
@dbale-altoros dbale-altoros changed the title feat: removed travis and added ci tests and linter via github workflow feat: removed travis and added automated tests via github workflow Feb 21, 2023
@dbale-altoros dbale-altoros mentioned this pull request Feb 21, 2023
Closed
@dbale-altoros dbale-altoros force-pushed the feat/add-github-action-to-test-repo branch from d5083e0 to 07dab49 Compare February 22, 2023 13:41
@dbale-altoros dbale-altoros marked this pull request as ready for review February 22, 2023 13:42
juanpcapurro
juanpcapurro approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@juanpcapurro juanpcapurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this ✨

README.md
@@ -8,7 +8,6 @@
[![Donate with Ethereum](https://en.cryptobadges.io/badge/micro/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)](https://en.cryptobadges.io/donate/0xe8cdf02efd8ab0a490d7b2cb13553389c9bc932e)

[![Gitter chat](https://badges.gitter.im/gitterHQ/gitter.svg)](https://gitter.im/solhint/Lobby)
[![Build Status](https://travis-ci.org/protofire/solhint.svg?branch=master)](https://travis-ci.org/protofire/solhint)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue to track removing the other broken badges #413

@fvictorio fvictorio force-pushed the feat/add-github-action-to-test-repo branch from 4e7c893 to 7fcbd04 Compare February 27, 2023 09:15
@fvictorio fvictorio force-pushed the feat/add-github-action-to-test-repo branch from 7fcbd04 to cda98d9 Compare February 27, 2023 09:18
@fvictorio fvictorio force-pushed the feat/add-github-action-to-test-repo branch 3 times, most recently from ebc6413 to 93b070f Compare February 27, 2023 09:52
@fvictorio fvictorio force-pushed the feat/add-github-action-to-test-repo branch from 93b070f to b4c4ce9 Compare February 27, 2023 10:01
@fvictorio fvictorio merged commit 769e171 into master Feb 27, 2023
@fvictorio fvictorio deleted the feat/add-github-action-to-test-repo branch February 27, 2023 10:04
@fvictorio
Copy link
Contributor

I had to skip a test on windows. I think this is a bug in node-glob, where a glob that is an absolute path (on windows) doesn't return the file. Either that, or the temporary file is being immediately deleted, not sure.

dbale-altoros pushed a commit that referenced this pull request Mar 6, 2023
@fvictorio @dbale-altoros
Merge pull request #412 from protofire/feat/add-github-action-to-test…
cde1bc6 
…-repo

feat: removed travis and added automated tests via github workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio approved these changes

@juanpcapurro juanpcapurro juanpcapurro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbale-altoros @fvictorio @juanpcapurro