Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @solidity-parser/parser #347

Closed
wants to merge 2 commits into from
Closed

Conversation

patrickd-
Copy link

This will add support for memory-safe assembly inline blocks:

-        assembly {
+        assembly ("memory-safe") {

as per https://docs.soliditylang.org/en/v0.8.13/assembly.html#memory-safety

Currently parsing errors due to the outdated version:

  195:17  error  Parse error: extraneous input '(' expecting {'{', StringLiteralFragment}
  195:31  error  Parse error: extraneous input ')' expecting '{'

The upgrade was successfully tested in the https://github.com/patrickd-/cheatsheet.sol repository

@k06a
Copy link

k06a commented Jun 23, 2022

Need this!

@PaulRBerg
Copy link
Contributor

Hey guys, is anyone still maintaining this repository? Sorry to tag you all but PRs like this are becoming a necessity in the latest versions of Solidity.

@fvictorio, @fernandomg, @idrabenia

@bretth18
Copy link

please merge this ASAP, ("memory-safe") is a somewhat common pattern

@dbale-altoros
Copy link
Collaborator

See this PR
Waiting for approval of other protofire team member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants