Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite squid URL with local API proxy #73

Merged
merged 12 commits into from
Nov 24, 2023
Merged

Rewrite squid URL with local API proxy #73

merged 12 commits into from
Nov 24, 2023

Conversation

henrypalacios
Copy link
Collaborator

@henrypalacios henrypalacios commented Nov 22, 2023 •
edited
Loading

  1. Avoid fetch Error, rewriting squid API URL to call from NextB backend
    image
  2. Keep Network selected after refresh app
    image

To test

Go to Visit Preview,

  1. Open app with /welcome page and you should not see failed fetch error.
  2. Select network on top bar and refresh page, you should see the network selected

@henrypalacios henrypalacios self-assigned this Nov 22, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 10:15pm
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 10:15pm

@henrypalacios henrypalacios changed the title Rewrites squid URL to such as local API Rewrite squid URL with local API proxy Nov 22, 2023
@henrypalacios henrypalacios requested review from camimancusi and matextrem and removed request for camimancusi and matextrem November 23, 2023 13:53
@camimancusi
Copy link
Collaborator

@henrypalacios approved ✅✅

@henrypalacios henrypalacios requested review from matextrem and removed request for camimancusi November 23, 2023 15:23
matextrem
matextrem approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@matextrem matextrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@henrypalacios henrypalacios merged commit 41ab005 into develop Nov 24, 2023
2 checks passed
@henrypalacios henrypalacios deleted the rewrites-squid-url branch November 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matextrem matextrem matextrem approved these changes

Assignees

@henrypalacios henrypalacios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrypalacios @camimancusi @matextrem