Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx page and elements interface #62

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

bogos
Copy link
Contributor

@bogos bogos commented Sep 25, 2023

  • Add Tx page
  • Add Tx Type by type (Send, Receive, Contract)
  • Add Tx Details by type
  • Update AccountAvatar element (src/components/AddressAccountSelect/AccountAvatar.tsx)

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 3:01am
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 3:01am

src/components/AddressAccountSelect/AccountAvatar.tsx Outdated Show resolved Hide resolved
src/components/AddressAccountSelect/AccountAvatar.tsx Outdated Show resolved Hide resolved
src/components/TxTable/TxDetail/SendDetail.tsx Outdated Show resolved Hide resolved
src/components/TxTable/TxDetailItem.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one nitpick

<Grid container>
{advancedDetails.map((detail) => (
<>
<Grid item {...DEFAULT_COL_WIDTH.name}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be the same as the new GridCol component? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change in the future, because it is not clear to me exactly which properties will be shown.

@bogos bogos requested a review from henrypalacios September 27, 2023 14:11
@henrypalacios henrypalacios merged commit 02d87fc into develop Sep 28, 2023
@henrypalacios henrypalacios deleted the feature/tx-page branch September 28, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants