Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Assets] Send tokens flow #61

Merged
merged 8 commits into from
Oct 17, 2023
Merged

[Assets] Send tokens flow #61

merged 8 commits into from
Oct 17, 2023

Conversation

matextrem
Copy link
Contributor

This PR has the following changes:

  • Added new send tokens flow.

@matextrem matextrem added the enhancement New feature or request label Sep 21, 2023
@matextrem matextrem self-assigned this Sep 21, 2023
@vercel
Copy link

vercel bot commented Sep 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:22pm
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 7:22pm

henrypalacios
henrypalacios requested changes Sep 22, 2023
View reviewed changes
src/components/SummaryCard/index.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/Review.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
@matextrem matextrem force-pushed the feature/send-tokens branch from e811bd9 to 684e36e Compare October 10, 2023 00:21
@matextrem matextrem force-pushed the feature/send-tokens branch from 684e36e to 0f73541 Compare October 11, 2023 18:18
henrypalacios
henrypalacios requested changes Oct 11, 2023
View reviewed changes
src/components/Transaction/index.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/Review.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/Review.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
henrypalacios
henrypalacios reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution 🤝

I have left out some aspects that I think can be improved and in terms of functionality the amount field is working in a strange way. I could not set a value like 0.12, 2 o 3

henrypalacios
henrypalacios requested changes Oct 11, 2023
View reviewed changes
src/pages/_app.tsx Outdated Show resolved Hide resolved
henrypalacios
henrypalacios approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job,
I leave just one nitpick

src/components/Transaction/steps/SendTokens.tsx Outdated Show resolved Hide resolved
@matextrem matextrem merged commit c4d1478 into develop Oct 17, 2023
2 checks passed
@matextrem matextrem deleted the feature/send-tokens branch October 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrypalacios henrypalacios henrypalacios approved these changes

Assignees

@matextrem matextrem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matextrem @henrypalacios