Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch network #21

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Switch network #21

merged 9 commits into from
Aug 16, 2023

Conversation

bogos
Copy link
Contributor

@bogos bogos commented Aug 11, 2023

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 10:15pm
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 10:15pm

@@ -31,17 +33,20 @@ export const ConnectButton: React.FC = () => {
return (
<>
{/* just to see which wallet was connected to*/}
<Avatar
{/* <Avatar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have commented on where it will be represented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

src/components/NetworkSelect/index.tsx Outdated Show resolved Hide resolved
src/components/NetworkSelect/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I leave some nitpicks

const chainId = event.target.value as ChainId;
onChange(chainId);
};
const chain = CHAINS_ALLOWED.find(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no use getChain on chains.ts?

return {
...chain,
logo: {
src: `${CHAINS_IMG_PATH}${chain.id}.png`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use default custom image if it does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants