Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Fix issues #113

Merged
merged 4 commits into from
Jan 8, 2024
Merged

[Settings] Fix issues #113

merged 4 commits into from
Jan 8, 2024

Conversation

matextrem
Copy link
Contributor

This PR addresses the following issues:

@matextrem matextrem added the bug Something isn't working label Jan 4, 2024
@matextrem matextrem requested a review from camimancusi January 4, 2024 03:59
@matextrem matextrem self-assigned this Jan 4, 2024
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 7:35pm
story-ink-multisig-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 7:35pm

@camimancusi
Copy link
Collaborator

❌Failed

  1. First time that you see the threshold, the total quantity of owner is shown as 1
    image

@camimancusi
Copy link
Collaborator

❌Failed

  1. When I want to add an owner, the review is not correct
add.owner.mp4

@camimancusi
Copy link
Collaborator

❌Failed
(A) The name of the owners (edition or addition) are not saved
(B) Add name + address of the owner to be removed in the modal of confirmation


✅1. First time that you see the threshold, the total quantity of owner is shown as 1
✅2. When I want to add an owner, the review is not correct
❌[Settings] The edition of an owner name (even creation) is saved just until the user closes the multisig. -> https://app.clickup.com/t/86a1t6yz9
✅[Settings - Add owner] If you roll back in the addition of an owner, you can not set a new one -> https://app.clickup.com/t/86a1ttkzg
✅[Settings - Remove owner] Add modal of confirmation before removing an owner -> https://app.clickup.com/t/86a1u5jd5
✅[Settings - Remove owner] When you remove an owner, all the trashes change to be on a loading status -> https://app.clickup.com/t/86a1u5j5t

@matextrem
Copy link
Contributor Author

@camimancusi fixed!

@camimancusi
Copy link
Collaborator

✅(A) The name of the owners (edition or addition) are not saved
✅(B) Add name + address of the owner to be removed in the modal of confirmation

@matextrem matextrem merged commit 7bceff0 into develop Jan 8, 2024
4 checks passed
@matextrem matextrem deleted the bugfix/settings-page branch January 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants