Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less user errors: automatically trim DDI and DDD #9

Closed
jonasmalacofilho opened this issue Jan 4, 2018 · 1 comment
Closed

Less user errors: automatically trim DDI and DDD #9

jonasmalacofilho opened this issue Jan 4, 2018 · 1 comment

Comments

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Jan 4, 2018 •
edited
Loading

Since our users are having a hard time with the definitions on what are DDIs and (even!) DDDs, we could:

  • strip leading 0, 00 and + from DDIs
  • strip leading 0 from DDD if and only if the DDI is 55
@jonasmalacofilho jonasmalacofilho changed the title Reduce the rate of user errors: automatically trim DDI and DDD Reduce user errors: automatically trim DDI and DDD Jan 4, 2018
@jonasmalacofilho jonasmalacofilho changed the title Reduce user errors: automatically trim DDI and DDD Less user errors: automatically trim DDI and DDD Jan 4, 2018
jonasmalacofilho added a commit that referenced this issue Jan 7, 2018
@jonasmalacofilho
Hide the DDI field to solve 35% of user/data errors (see #9)
3c58537 
So far, no user has correctly requested a card using a phonenumber with
a different country code.
@jonasmalacofilho
Copy link
Member Author

Fixed in v1.1.0 (by commit 3c58537).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasmalacofilho