Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup kokoro scripts. #5027

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Cleanup kokoro scripts. #5027

merged 1 commit into from
Aug 9, 2018

Conversation

xfxyjwf
Copy link
Contributor

@xfxyjwf xfxyjwf commented Aug 9, 2018

Changes:

  1. Remove stuff no longer needed. Lots of the heavy lifting were there
    because we were running our own jenkins cluster and had to manage all
    the test logs ourselves. Now they are useless.
  2. Change "-j2" to "-j4" to speed up the test a little bit. Kokoro
    machines have 4 logic CPUs according to their spec.

Changes:
1. Remove stuff no longer needed. Lots of the heavy lifting were there
because we were running our own jenkins cluster and had to manage all
the test logs ourselves. Now they are useless.
2. Change "-j2" to "-j4" to speed up the test a little bit. Kokoro
machines have 4 logic CPUs according to their spec.
@xfxyjwf
Copy link
Contributor Author

xfxyjwf commented Aug 9, 2018

This PR improves the running time of linux tests significantly because it has removed the C++ test that was there for every language. For example, linux Python:

Before: 22 mins
https://source.cloud.google.com/results/invocations/dd2181b6-af9c-4035-9c27-8f8695a7de18/targets

After: 10 mins
https://source.cloud.google.com/results/invocations/0f623ded-e412-41bc-bf6f-f9b0f25dfc47/targets

@xfxyjwf xfxyjwf merged commit fe80059 into protocolbuffers:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants