Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Include .inc files directly instead of through a filegroup #14575

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Cherry-pick: Include .inc files directly instead of through a filegroup #14575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion upb/port/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ cc_library(
"vsnprintf_compat.h",
],
copts = UPB_DEFAULT_COPTS,
textual_hdrs = [":inc"],
textual_hdrs = [
# We must list the headers explicitly here instead of relying on the
# :inc filegroup below. gRPC auto-generates various build configs from
# the Bazel graph, and this logic does not know how to handle
# filegroups. We might be able to replace these headers with just
# ":inc" after gRPC starts using upb's CMake build.
"def.inc",
"undef.inc",
],
visibility = ["//visibility:public"],
)

Expand Down