Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that ffi-compiler loads before using it to define tasks. #14538

Closed
wants to merge 2 commits into from
Closed

Check that ffi-compiler loads before using it to define tasks. #14538

wants to merge 2 commits into from

Conversation

JasonLunn
Copy link
Contributor

Fixes #14509

@JasonLunn JasonLunn requested a review from a team as a code owner October 26, 2023 19:11
@JasonLunn JasonLunn requested review from haberman and removed request for a team October 26, 2023 19:11
@JasonLunn JasonLunn added ruby 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Oct 26, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 26, 2023
@JasonLunn JasonLunn mentioned this pull request Oct 26, 2023
Closed
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 27, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 27, 2023
@JasonLunn JasonLunn added the 25.x label Oct 27, 2023
@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 27, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 27, 2023
@copybara-service copybara-service bot mentioned this pull request Oct 27, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Oct 27, 2023
@JasonLunn @copybara-github
Check that ffi-compiler loads before using it to define tasks. (#14538)
d41925f 
Fixes #14509

Closes #14538

COPYBARA_INTEGRATE_REVIEW=#14538 from JasonLunn:fix_14509 a3f9d0b
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14538 from JasonLunn:fix_14509 a3f9d0b
PiperOrigin-RevId: 577284877
zhangskz pushed a commit that referenced this pull request Oct 31, 2023
@JasonLunn @zhangskz
Check that ffi-compiler loads before using it to define tasks. (#14538)
4dd97cf 
Fixes #14509

Closes #14538

COPYBARA_INTEGRATE_REVIEW=#14538 from JasonLunn:fix_14509 a3f9d0b
PiperOrigin-RevId: 577837541
@zhangskz zhangskz mentioned this pull request Oct 31, 2023
Merged
zhangskz added a commit that referenced this pull request Oct 31, 2023
@zhangskz @JasonLunn
Check that ffi-compiler loads before using it to define tasks. (#14538)…
0a5d6d4 
… (#14560)

Fixes #14509

Closes #14538

COPYBARA_INTEGRATE_REVIEW=#14538 from JasonLunn:fix_14509 a3f9d0b
PiperOrigin-RevId: 577837541

Co-authored-by: Jason Lunn <jason.lunn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangskz zhangskz zhangskz approved these changes

@haberman haberman Awaiting requested review from haberman haberman is a code owner automatically assigned from protocolbuffers/protobuf-ruby

Assignees
No one assigned
Labels
25.x ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install 3.25.0.rc.2 on Ruby 3.3.0-preview2
2 participants
@JasonLunn @zhangskz