Make the MergeFrom method of type ReadOnlySequence<byte> public #11124
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I'll need to carefully consider the impact of this on various versions etc. I'm still finishing up work from going on vacation, so I won't even be able to look at this until January. It may not make it into the next version; we'll see. |
|
Great !!! This is positive. |
|
Right, I've now had a better chance to evaluate this, and it looks fine. I've edited the PR description so that it'll be easier to create release notes. |
|
@deannagarcia: This should be included in the next C# release. I'm happy for it to either stay here as a PR and get included via Copybara when that work is complete, or force-merged now. Let me know what you think. |
|
Can you rebase this PR so we can get it submitted? |
|
@deannagarcia: I may well be able to do that myself. Will give it a try. |
|
@deannagarcia: Done. Will run Kokoro as well... |
Thanks for @jskeet 's help. :) |
|
I'm going to rebase and repush this PR so that it has a recent HEAD - I believe that we'll then be able to get this merged. |
Public the MergeFrom method of type ReadOnlySequence<byte>
|
(Rebased again... I'm going to really try to get this all green today...) |
(Edited by jskeet) For public release notes:
Add a public
IMessage.MergeFrom(ReadOnlySequence<byte>)extension method, exposing existing internal functionality.(Parsing a completely new message from
ReadOnlySequence<byte>was already publicly available, just not merging.)Public the
MergeFrommethod of typeReadOnlySequence<byte>.We found that the
MergeFrommethod of typeReadOnlySequence<byte>is internal.We need it !!!