fix: PHP readonly legacy files for nested messages #10320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
approved these changes
Jul 27, 2022
haberman
approved these changes
Aug 2, 2022
|
Should this be cherry-picked into 21.x? |
|
seems likely. Do you mind sending me a PR for that? |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…ith-nested-messages fix: PHP readonly legacy files for nested messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10041 we added escaping for PHP's
ReadOnlykeyword, but this misses writing the backwards compatibility file when the message is nested. For example, the fileNested\ReadOnly.phpis not written for the protomessage nested { message readonly {} }.This fortunately should not cause any issues with existing users, as this file is only for compatibility, and without it, the previous message file remains (and works as expected). But as the previous
ReadOnly.phpthrow a PHP fatal error on PHP 8.1, the result is that anyone upgrading to PHP 8.1 and still using theReadOnlykeyword will still receive a PHP fatal error.This is an edge case, but still one we should fix.