Skip to content

Commit

Permalink
Revert workaround for std::mutex issues on github windows runners.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 648802955
  • Loading branch information
mkruskal-google authored and zhangskz committed Jul 15, 2024
1 parent 861be78 commit ba3e7d7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions protos/protos_extension_lock_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ void TestConcurrentExtensionAccess(::protos::ExtensionRegistry registry) {
test_theme();
test_theme_extension();
}
#ifndef _MSC_VER
// TODO Re-enable this once github runner issue is resolved.

TEST(CppGeneratedCode, ConcurrentAccessDoesNotRaceBothLazy) {
::upb::Arena arena;
Expand All @@ -122,7 +120,5 @@ TEST(CppGeneratedCode, ConcurrentAccessDoesNotRaceBothEager) {
{{&theme, &ThemeExtension::theme_extension}, arena});
}

#endif // _MSC_VER

} // namespace
} // namespace protos_generator::test::protos
3 changes: 0 additions & 3 deletions src/google/protobuf/compiler/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ namespace protobuf {
namespace compiler {

int ProtobufMain(int argc, char* argv[]) {
#ifndef _MSC_VER
// TODO Re-enable this once github runner issue is resolved.
absl::InitializeLog();
#endif // !_MSC_VER

CommandLineInterface cli;
cli.AllowPlugins("protoc-");
Expand Down
3 changes: 0 additions & 3 deletions src/google/protobuf/compiler/main_no_generators.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ namespace compiler {
// This is a version of protoc that has no built-in code generators.
// See go/protobuf-toolchain-protoc
int ProtocMain(int argc, char* argv[]) {
#ifndef _MSC_VER
// TODO Re-enable this once github runner issue is resolved.
absl::InitializeLog();
#endif // !_MSC_VER

CommandLineInterface cli;
cli.AllowPlugins("protoc-");
Expand Down

0 comments on commit ba3e7d7

Please sign in to comment.