Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade role/rolebinding apiVersion and keep backward compatibility #91

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

etiennetremel
Copy link
Contributor

rbac.authorization.k8s.io/v1beta1 has been removed since kubernetes v1.22.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 29, 2021
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll ship this patch asap.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 1, 2022
@tomkerkhove
Copy link
Member

And thanks for the contribution!

@tomkerkhove tomkerkhove merged commit fdf810e into promitor:main Jan 1, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Jan 1, 2022
@tomkerkhove
Copy link
Member

Released, thank you @etiennetremel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants