Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide support for using pre-created secret and populate env vars #49

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

tomkerkhove
Copy link
Member

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Fixes #48

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove
Copy link
Member Author

@TimDurward PTAL

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jun 20, 2021
@TimDurward
Copy link

Looks good to me! 👍

@tomkerkhove tomkerkhove merged commit a02be98 into main Jun 21, 2021
@tomkerkhove tomkerkhove deleted the create-secret-bug branch June 21, 2021 06:01
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't leave azureAuthentication.identity.key blank when using your own secrets (secrets.createSecret: false)
2 participants